linux-kernel - Re: [PATCH v14 18/18] media: i2c: ds90ub953: Support non-sync mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dc79de4e-4043-5448-db44-ef8f7749a376@ideasonboard.com>
Date:   Mon, 19 Jun 2023 12:00:57 +0300
From:   Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To:     Andy Shevchenko <andriy.shevchenko@...el.com>
Cc:     linux-media@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
        Luca Ceresoli <luca.ceresoli@...tlin.com>,
        Matti Vaittinen <Matti.Vaittinen@...rohmeurope.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Wolfram Sang <wsa@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Peter Rosin <peda@...ntia.se>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Michael Tretter <m.tretter@...gutronix.de>,
        Hans Verkuil <hverkuil@...all.nl>,
        Mike Pagano <mpagano@...too.org>,
        Krzysztof Hałasa <khalasa@...p.pl>,
        Marek Vasut <marex@...x.de>,
        Satish Nagireddy <satish.nagireddy@...cruise.com>
Subject: Re: [PATCH v14 18/18] media: i2c: ds90ub953: Support non-sync mode

On 16/06/2023 17:47, Andy Shevchenko wrote:
> On Fri, Jun 16, 2023 at 04:59:22PM +0300, Tomi Valkeinen wrote:
>> Add support for FPD-Link non-sync mode with external clock. The only
>> thing that needs to be added is the calculation for the clkout.
> 
> ...
> 
>> +	switch (priv->mode) {
>> +	case UB953_MODE_SYNC:
>> +		if (priv->hw_data->is_ub971)
>> +			return priv->plat_data->bc_rate * 160ull;
>> +		else
>> +			return priv->plat_data->bc_rate / 2 * 160ull;
> 
> Redundant 'else'.

True, but I like the symmetry in:

if (foo)
	return 123;
else
	return 321;

> Do I understand correctly you don't want to fallthrough because it will give
> ±160 in the rate (depending if it's even or odd)?

Sorry, can you clarify? Fallthrough to what?

>> +	case UB953_MODE_NONSYNC_EXT:
>> +		/* CLKIN_DIV = 1 always */
>> +		return clk_get_rate(priv->clkin) * 80ull;
>> +
>> +	default:
>>   		/* Not supported */
>>   		return 0;
>>   	}
>