linux-kernel - Re: [PATCH V3 3/7] drm/amd/pm: update driver_if and ppsmc headers for coming wbrf feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6386e0a4-3cea-e691-e33f-d4617812e8c6@amd.com>
Date:   Sun, 18 Jun 2023 21:18:03 -0500
From:   Mario Limonciello <mario.limonciello@....com>
To:     Evan Quan <evan.quan@....com>, rafael@...nel.org, lenb@...nel.org,
        Alexander.Deucher@....com, Christian.Koenig@....com,
        Xinhui.Pan@....com, airlied@...il.com, daniel@...ll.ch,
        kvalo@...nel.org, nbd@....name, lorenzo@...nel.org,
        ryder.lee@...iatek.com, shayne.chen@...iatek.com,
        sean.wang@...iatek.com, matthias.bgg@...il.com,
        angelogioacchino.delregno@...labora.com, Lijo.Lazar@....com
Cc:     linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
        amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-wireless@...r.kernel.org
Subject: Re: [PATCH V3 3/7] drm/amd/pm: update driver_if and ppsmc headers for
 coming wbrf feature

On 6/16/23 01:57, Evan Quan wrote:
> Add those data structures to support Wifi RFI mitigation feature.
> 
> Signed-off-by: Evan Quan <evan.quan@....com>

Reviewed-by: Mario Limonciello <mario.limonciello@....com>

> ---
>   .../pm/swsmu/inc/pmfw_if/smu13_driver_if_v13_0_0.h | 14 +++++++++++++-
>   .../pm/swsmu/inc/pmfw_if/smu13_driver_if_v13_0_7.h | 14 +++++++++++++-
>   .../amd/pm/swsmu/inc/pmfw_if/smu_v13_0_0_ppsmc.h   |  3 ++-
>   .../amd/pm/swsmu/inc/pmfw_if/smu_v13_0_7_ppsmc.h   |  3 ++-
>   4 files changed, 30 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu13_driver_if_v13_0_0.h b/drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu13_driver_if_v13_0_0.h
> index b686fb68a6e7..d64188fb5839 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu13_driver_if_v13_0_0.h
> +++ b/drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu13_driver_if_v13_0_0.h
> @@ -388,6 +388,17 @@ typedef struct {
>     EccInfo_t  EccInfo[24];
>   } EccInfoTable_t;
>   
> +typedef struct {
> +  uint16_t     LowFreq;
> +  uint16_t     HighFreq;
> +} WifiOneBand_t;
> +
> +typedef struct {
> +  uint32_t         WifiBandEntryNum;
> +  WifiOneBand_t    WifiBandEntry[11];
> +  uint32_t         MmHubPadding[8];
> +} WifiBandEntryTable_t;
> +
>   //D3HOT sequences
>   typedef enum {
>     BACO_SEQUENCE,
> @@ -1592,7 +1603,8 @@ typedef struct {
>   #define TABLE_I2C_COMMANDS            9
>   #define TABLE_DRIVER_INFO             10
>   #define TABLE_ECCINFO                 11
> -#define TABLE_COUNT                   12
> +#define TABLE_WIFIBAND                12
> +#define TABLE_COUNT                   13
>   
>   //IH Interupt ID
>   #define IH_INTERRUPT_ID_TO_DRIVER                   0xFE
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu13_driver_if_v13_0_7.h b/drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu13_driver_if_v13_0_7.h
> index 4c46a0392451..77483e8485e7 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu13_driver_if_v13_0_7.h
> +++ b/drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu13_driver_if_v13_0_7.h
> @@ -392,6 +392,17 @@ typedef struct {
>     EccInfo_t  EccInfo[24];
>   } EccInfoTable_t;
>   
> +typedef struct {
> +  uint16_t     LowFreq;
> +  uint16_t     HighFreq;
> +} WifiOneBand_t;
> +
> +typedef struct {
> +  uint32_t         WifiBandEntryNum;
> +  WifiOneBand_t    WifiBandEntry[11];
> +  uint32_t         MmHubPadding[8];
> +} WifiBandEntryTable_t;
> +
>   //D3HOT sequences
>   typedef enum {
>     BACO_SEQUENCE,
> @@ -1624,7 +1635,8 @@ typedef struct {
>   #define TABLE_I2C_COMMANDS            9
>   #define TABLE_DRIVER_INFO             10
>   #define TABLE_ECCINFO                 11
> -#define TABLE_COUNT                   12
> +#define TABLE_WIFIBAND                12
> +#define TABLE_COUNT                   13
>   
>   //IH Interupt ID
>   #define IH_INTERRUPT_ID_TO_DRIVER                   0xFE
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_0_ppsmc.h b/drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_0_ppsmc.h
> index 10cff75b44d5..c98cc32d11bd 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_0_ppsmc.h
> +++ b/drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_0_ppsmc.h
> @@ -138,7 +138,8 @@
>   #define PPSMC_MSG_SetBadMemoryPagesRetiredFlagsPerChannel 0x4A
>   #define PPSMC_MSG_SetPriorityDeltaGain           0x4B
>   #define PPSMC_MSG_AllowIHHostInterrupt           0x4C
> -#define PPSMC_Message_Count                      0x4D
> +#define PPSMC_MSG_EnableUCLKShadow               0x51
> +#define PPSMC_Message_Count                      0x52
>   
>   //Debug Dump Message
>   #define DEBUGSMC_MSG_TestMessage                    0x1
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_7_ppsmc.h b/drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_7_ppsmc.h
> index 6aaefca9b595..a6bf9cdd130e 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_7_ppsmc.h
> +++ b/drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_7_ppsmc.h
> @@ -134,6 +134,7 @@
>   #define PPSMC_MSG_SetBadMemoryPagesRetiredFlagsPerChannel 0x4A
>   #define PPSMC_MSG_SetPriorityDeltaGain           0x4B
>   #define PPSMC_MSG_AllowIHHostInterrupt           0x4C
> -#define PPSMC_Message_Count                      0x4D
> +#define PPSMC_MSG_EnableUCLKShadow               0x51
> +#define PPSMC_Message_Count                      0x52
>   
>   #endif