linux-kernel - Re: [PATCH] kbuild: make clean rule robust against too long argument error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230619093233.GB20014@lxhi-065>
Date:   Mon, 19 Jun 2023 11:32:33 +0200
From:   Eugeniu Rosca <erosca@...adit-jv.com>
To:     Masahiro Yamada <masahiroy@...nel.org>
CC:     Eugeniu Rosca <erosca@...adit-jv.com>,
        <linux-kbuild@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Nicolas Schier <nicolas@...sle.eu>,
        Eugeniu Rosca <roscaeugeniu@...il.com>
Subject: Re: [PATCH] kbuild: make clean rule robust against too long argument
 error

Hello Yamada-san,

On Mon, Jun 19, 2023 at 12:50:48AM +0900, Masahiro Yamada wrote:
> On Sun, Jun 18, 2023 at 5:07 AM Eugeniu Rosca <erosca@...adit-jv.com> wrote:

[snip]

> > Please, correct me if I am wrong, but it looks like the magic/brilliance
> > is in the 'patsubst' function, since below version also fails for me:
> >
> > NOK: cmd_clean = printf '%s ' $(__clean-files) | xargs rm -rf
> 
> Right.
> Now, 'printf' (instead of 'rm') failed with the too long argument list.
> 
> GNU Make does not have the length limit, but shell does.
> So, the full-path list must be passed via stdout
> instead of the command line.
> 
> 
> The comment might be confusing.
> 
> I will repeat the same comment written in scripts/Makefile.build:
> 
>   # To make this rule robust against "Argument list too long" error,
>   # remove $(obj)/ prefix, and restore it by a shell command.

Sounds good to me. No open questions from my end :)

-- 
Best regards,
Eugeniu Rosca