[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <7eda291f-1e2a-1af6-ae25-785b6eccc281@oss.nxp.com>
Date: Mon, 19 Jun 2023 12:46:22 +0300
From: "Radu Pirea (OSS)" <radu-nicolae.pirea@....nxp.com>
To: Horatiu Vultur <horatiu.vultur@...rochip.com>
Cc: andrew@...n.ch, hkallweit1@...il.com, linux@...linux.org.uk,
davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
pabeni@...hat.com, richardcochran@...il.com,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
sebastian.tobuschat@....com
Subject: Re: [PATCH net-next v1 14/14] net: phy: nxp-c45-tja11xx: timestamp
reading workaround for TJA1120
On 19.06.2023 11:58, Horatiu Vultur wrote:
> The 06/16/2023 16:53, Radu Pirea (NXP OSS) wrote:
>
> Hi Radu,
>
>>
>> On TJA1120 engineering samples, the new timestamp is stuck in the FIFO.
>> If the MORE_TS bit is set and the VALID bit is not set, we know that we
>> have a timestamp in the FIFO but not in the buffer.
>>
>> To move the new timestamp in the buffer registers, the current
>> timestamp(which is invalid) is unlocked by writing any of the buffer
>> registers.
>
> Shouldn't this be split and merged in patch 9 and patch 10?
> As those two patches introduced this functions with issues.
>
Ok. I will merge the workarounds in patches 9 and 12 if it looks better
to you. The intention here was to implement the timestamp reading
sequence in a clean way and to add the workarounds later.
>>
>>
>
> --
> /Horatiu
--
Radu P.
Powered by blists - more mailing lists