linux-kernel - Re: [PATCH] s390/net: lcs: use IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4f2afa34-830a-3c17-99e7-1cb5b874e7ce@linux.ibm.com>
Date:   Mon, 19 Jun 2023 12:04:15 +0200
From:   Alexandra Winter <wintera@...ux.ibm.com>
To:     patchwork-bot+netdevbpf@...nel.org,
        Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org, wenjia@...ux.ibm.com,
        linux-s390@...r.kernel.org, netdev@...r.kernel.org,
        hca@...ux.ibm.com, gor@...ux.ibm.com, agordeev@...ux.ibm.com,
        borntraeger@...ux.ibm.com, svens@...ux.ibm.com
Subject: Re: [PATCH] s390/net: lcs: use IS_ENABLED() for kconfig detection



On 16.06.23 10:10, patchwork-bot+netdevbpf@...nel.org wrote:
> Hello:
> 
> This patch was applied to netdev/net-next.git (main)
> by David S. Miller <davem@...emloft.net>:
> 
> On Thu, 15 Jun 2023 15:21:52 -0700 you wrote:
>> When CONFIG_ETHERNET=m or CONFIG_FDDI=m, lcs.s has build errors or
>> warnings:
>>
 
IIUC, CONFIG_ETHERNET is bool.
I reproduced this with CONFIG_ETHERNET=n and CONFIG_FDDI=m,
and verified that it does compile with your patch.

Thank you Randy for correcting this.

>> ../drivers/s390/net/lcs.c:40:2: error: #error Cannot compile lcs.c without some net devices switched on.
>>    40 | #error Cannot compile lcs.c without some net devices switched on.
>> ../drivers/s390/net/lcs.c: In function 'lcs_startlan_auto':
>> ../drivers/s390/net/lcs.c:1601:13: warning: unused variable 'rc' [-Wunused-variable]
>>  1601 |         int rc;
>>
>> [...]
> 
> Here is the summary with links:
>   - s390/net: lcs: use IS_ENABLED() for kconfig detection
>     https://git.kernel.org/netdev/net-next/c/128272336120
> 
> You are awesome, thank you!