linux-kernel - Re: [PATCH v1 1/1] gpiolib: Drop unused domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZJAw507ODTUX2elD@smile.fi.intel.com>
Date:   Mon, 19 Jun 2023 13:41:43 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Marc Zyngier <maz@...nel.org>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Thierry Reding <treding@...dia.com>,
        Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Bartosz Golaszewski <brgl@...ev.pl>
Subject: Re: [PATCH v1 1/1] gpiolib: Drop unused domain_ops memeber of GPIO
 IRQ chip

On Sat, Jun 17, 2023 at 11:23:17AM +0100, Marc Zyngier wrote:
> On Sat, 17 Jun 2023 10:08:10 +0100,
> Linus Walleij <linus.walleij@...aro.org> wrote:
> > On Fri, Jun 16, 2023 at 3:53 PM Andy Shevchenko
> > <andriy.shevchenko@...ux.intel.com> wrote:

(...)

> > > -               /* Some drivers provide custom irqdomain ops */
> > >                 gc->irq.domain = irq_domain_create_simple(fwnode,
> > >                         gc->ngpio,
> > >                         gc->irq.first,
> > > -                       gc->irq.domain_ops ?: &gpiochip_domain_ops,
> > > +                       &gpiochip_domain_ops,
> > 
> > We better run this by Marc Zyngier, and Thierry who introduced it.
> > 
> > But some grepping and looking seems to conclude you are righ!
> > Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
> 
> No objection from my end. If this is unused, let's kill it.

Grepping by two independent people and so far no complains from CI, I believe
the patch tells truth.

> Acked-by: Marc Zyngier <maz@...nel.org>

Thank you!

-- 
With Best Regards,
Andy Shevchenko