linux-kernel - Re: [PATCH] list: Remove unnecessary WRITE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJgM1-SBzHXDdur+MgK2cBBeOacKOWz=zPyEa2mee3fOw@mail.gmail.com>
Date:   Mon, 19 Jun 2023 13:02:27 +0200
From:   Eric Dumazet <edumazet@...gle.com>
To:     Alan Huang <mmpgouride@...il.com>
Cc:     paulmck@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] list: Remove unnecessary WRITE_ONCE()

On Mon, Jun 19, 2023 at 11:03 AM Alan Huang <mmpgouride@...il.com> wrote:
>
> Commit c54a2744497d("list: Add hlist_unhashed_lockless()") added
> various WRITE_ONCE() to pair with the READ_ONCE() in
> hlist_unhashed_lockless(), but there is no need to protect
> ->next with WRITE_ONCE(). Therefore, this commit removes those
> unnecessary WRITE_ONCE().

Why are they unnecessary ?
They seem just fine to me.
Please elaborate.