[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <598c14f9-395c-d218-4af9-31bba022dcf6@linaro.org>
Date: Mon, 19 Jun 2023 14:23:25 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Yann Gautier <yann.gautier@...s.st.com>,
Ulf Hansson <ulf.hansson@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
linux-mmc@...r.kernel.org, devicetree@...r.kernel.org
Cc: Conor Dooley <conor+dt@...nel.org>,
Russell King <linux@...linux.org.uk>,
Philipp Zabel <p.zabel@...gutronix.de>,
Christophe Kerello <christophe.kerello@...s.st.com>,
linux-kernel@...r.kernel.org, Marek Vasut <marex@...x.de>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Linus Walleij <linus.walleij@...aro.org>,
Yang Yingliang <yangyingliang@...wei.com>,
Xiang wangx <wangxiang@...rlc.com>,
linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 1/6] dt-bindings: mmc: mmci: Add st,stm32mp25-sdmmc2
compatible
On 19/06/2023 13:51, Yann Gautier wrote:
> For STM32MP25, we'll need to distinguish how is managed the delay block.
> This is done through a new comptible dedicated for this SoC, as the
> delay block registers are located in SYSCFG peripheral.
>
> Signed-off-by: Yann Gautier <yann.gautier@...s.st.com>
> ---
> Changes in v2:
> - update dt-bindings file (remove bootloader reference and use enum)
>
> Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
> index 1c96da04f0e53..2459a55ed540b 100644
> --- a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
> +++ b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
> @@ -53,10 +53,11 @@ properties:
> items:
> - const: arm,pl18x
> - const: arm,primecell
> - - description: Entry for STMicroelectronics variant of PL18x.
> - This dedicated compatible is used by bootloaders.
> + - description: Entries for STMicroelectronics variant of PL18x.
> items:
> - - const: st,stm32-sdmmc2
> + - enum:
> + - st,stm32-sdmmc2
> + - st,stm32mp25-sdmmc2
It's nicely visible that old stm32 entry was family-generic, not
device-specific, thus not really correct. :( I hope we can learn from
this for future stm submissions.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Best regards,
Krzysztof
Powered by blists - more mailing lists