linux-kernel - Re: [PATCH 06/15] arm64: dts: qcom: msm8996-xiaomi: drop label from I2C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <41cfcaea-e03f-6abc-6cb5-194eeefc12bd@linaro.org>
Date:   Mon, 19 Jun 2023 15:13:02 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        cros-qcom-dts-watchers@...omium.org,
        Nikita Travkin <nikita@...n.ru>,
        Stephan Gerhold <stephan@...hold.net>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 06/15] arm64: dts: qcom: msm8996-xiaomi: drop label from
 I2C

On 17.06.2023 19:15, Krzysztof Kozlowski wrote:
> I2C controller bindings do not allow label property:
> 
>   msm8996-xiaomi-gemini.dtb: i2c@...6000: Unevaluated properties are not allowed ('label' was unexpected)
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad
>  arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
> index 47f55c7311e9..8c2d6e9e851b 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
> @@ -187,7 +187,6 @@ &adsp_pil {
>  
>  &blsp2_i2c2 {
>  	status = "okay";
> -	label = "NFC_I2C";
>  	clock-frequency = <400000>;
>  
>  	nfc: pn548@28 {
> @@ -208,7 +207,6 @@ nfc: pn548@28 {
>  
>  &blsp2_i2c3 {
>  	status = "okay";
> -	label = "TYPEC_I2C";
>  
>  	typec: tusb320l@47 {
>  		compatible = "ti,tusb320l";
> @@ -220,7 +218,7 @@ typec: tusb320l@47 {
>  
>  &blsp2_i2c6 {
>  	status = "okay";
> -	label = "MSM_TS_I2C";
> +	/* MSM_TS */
>  };
>  
>  &blsp1_uart2 {