linux-kernel - Re: [PATCH v2] Revert "8250: add support for ASIX devices with a FIFO bug"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2023061950-unrigged-dosage-59e2@gregkh>
Date:   Mon, 19 Jun 2023 15:42:13 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Jiaqing Zhao <jiaqing.zhao@...ux.intel.com>
Cc:     linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH v2] Revert "8250: add support for ASIX devices with a
 FIFO bug"

On Mon, Jun 19, 2023 at 10:08:19AM +0000, Jiaqing Zhao wrote:
> Commit eb26dfe8aa7e ("8250: add support for ASIX devices with a FIFO
> bug") merged on Jul 13, 2012 adds a quirk for PCI_VENDOR_ID_ASIX
> (0x9710). But that ID is the same as PCI_VENDOR_ID_NETMOS defined in
> 1f8b061050c7 ("[PATCH] Netmos parallel/serial/combo support") merged
> on Mar 28, 2005. In pci_serial_quirks array, the NetMos entry always
> takes precedence over the ASIX entry even since it was initially
> merged, code in that commit is always unreachable.
> 
> In my tests adding the FIFO workaround to pci_netmos_init() makes no
> difference, and the vendor driver also does not have such workaround.
> Given that the code was never used for over a decade, it's safe to
> revert it.
> 
> Also, the real PCI_VENDOR_ID_ASIX should be 0x125b, which is used on
> their newer AX99100 PCIe serial controllers released on 2016. The FIFO
> workaround should not be intended for these newer controllers, and it
> was never implemented in vendor driver.
> 
> This reverts commit eb26dfe8aa7eeb5a5aa0b7574550125f8aa4c3b3.
> 
> Signed-off-by: Jiaqing Zhao <jiaqing.zhao@...ux.intel.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Fails to apply to my tree :(

Can you rebase this against the tty-next branch of my tty.git tree on
kernel.org?

thanks,

greg k-h