linux-kernel - Re: [PATCH] drm/amdgpu: Add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230619164219.4ae6a818@gollum>
Date:   Mon, 19 Jun 2023 16:42:19 +0200
From:   Juerg Haefliger <juerg.haefliger@...onical.com>
To:     Alex Deucher <alexdeucher@...il.com>
Cc:     alexander.deucher@....com, christian.koenig@....com,
        Xinhui.Pan@....com, airlied@...il.com, daniel@...ll.ch,
        amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        Bokun.Zhang@....com, lijo.lazar@....com,
        linux-kernel@...r.kernel.org, YiPeng.Chai@....com,
        mario.limonciello@....com, Likun.Gao@....com, Hawking.Zhang@....com
Subject: Re: [PATCH] drm/amdgpu: Add missing MODULE_FIRMWARE macro

On Fri, 16 Jun 2023 08:53:20 -0400
Alex Deucher <alexdeucher@...il.com> wrote:

> On Fri, Jun 16, 2023 at 8:11 AM Juerg Haefliger
> <juerg.haefliger@...onical.com> wrote:
> >
> > Add the missing MODULE_FIRMWARE macro for "amdgpu/fiji_smc.bin".
> >
> > Signed-off-by: Juerg Haefliger <juerg.haefliger@...onical.com>
> > ---
> >  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> > index 5c7d40873ee2..1f83a939d641 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> > @@ -92,6 +92,7 @@ MODULE_FIRMWARE("amdgpu/picasso_gpu_info.bin");
> >  MODULE_FIRMWARE("amdgpu/raven2_gpu_info.bin");
> >  MODULE_FIRMWARE("amdgpu/arcturus_gpu_info.bin");
> >  MODULE_FIRMWARE("amdgpu/navi12_gpu_info.bin");
> > +MODULE_FIRMWARE("amdgpu/fiji_smc.bin");  
> 
> This is already specified in smumgr.c.

It sure is. Sorry for the noise :-(

Thanks for looking at it.
..Juerg

 
> Alex
> 
> >
> >  #define AMDGPU_RESUME_MS               2000
> >  #define AMDGPU_MAX_RETRY_LIMIT         2
> > --
> > 2.37.2
> >  


Content of type "application/pgp-signature" skipped