linux-kernel - Re: [PATCH v3 11/12] thermal/drivers/generic-adc: Register thermal zones as hwmon sensors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGb2v65xzhzVp+pBsa_Z3aHtK4LOpiTbhA749doMpwSTwDtxCg@mail.gmail.com>
Date:   Mon, 19 Jun 2023 23:33:10 +0800
From:   Chen-Yu Tsai <wens@...e.org>
To:     Matthias Brugger <matthias.bgg@...il.com>
Cc:     Yangtao Li <frank.li@...o.com>, glaroque@...libre.com,
        rafael@...nel.org, daniel.lezcano@...aro.org, amitk@...nel.org,
        rui.zhang@...el.com, shawnguo@...nel.org, s.hauer@...gutronix.de,
        kernel@...gutronix.de, festevam@...il.com, linux-imx@....com,
        thara.gopinath@...il.com, agross@...nel.org, andersson@...nel.org,
        konrad.dybcio@...aro.org, anarsoul@...il.com,
        tiny.windzz@...il.com, jernej.skrabec@...il.com,
        samuel@...lland.org, thierry.reding@...il.com,
        jonathanh@...dia.com, edubezval@...il.com, j-keerthy@...com,
        angelogioacchino.delregno@...labora.com, bchihi@...libre.com,
        niklas.soderlund+renesas@...natech.se, wenst@...omium.org,
        linux-pm@...r.kernel.org, linux-amlogic@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-arm-msm@...r.kernel.org, linux-sunxi@...ts.linux.dev,
        linux-tegra@...r.kernel.org, linux-omap@...r.kernel.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v3 11/12] thermal/drivers/generic-adc: Register thermal
 zones as hwmon sensors

On Mon, Jun 19, 2023 at 11:17 PM Matthias Brugger
<matthias.bgg@...il.com> wrote:
>
>
>
> On 13/06/2023 13:49, Yangtao Li wrote:
> > From: Chen-Yu Tsai <wenst@...omium.org>
> >
> > Register thermal zones as hwmon sensors to let userspace read
> > temperatures using standard hwmon interface.
> >
> > Signed-off-by: Chen-Yu Tsai <wenst@...omium.org>
> > [Yangtao change to use dev_warn and remove return]
> > Signed-off-by: Yangtao Li <frank.li@...o.com>
> > ---
> >   drivers/thermal/thermal-generic-adc.c | 5 +++++
> >   1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/thermal/thermal-generic-adc.c b/drivers/thermal/thermal-generic-adc.c
> > index 017b0ce52122..9531bc2f2ce7 100644
> > --- a/drivers/thermal/thermal-generic-adc.c
> > +++ b/drivers/thermal/thermal-generic-adc.c
> > @@ -13,6 +13,8 @@
> >   #include <linux/slab.h>
> >   #include <linux/thermal.h>
> >
> > +#include "thermal_hwmon.h"
> > +
> >   struct gadc_thermal_info {
> >       struct device *dev;
> >       struct thermal_zone_device *tz_dev;
> > @@ -153,6 +155,9 @@ static int gadc_thermal_probe(struct platform_device *pdev)
> >               return ret;
> >       }
> >
> > +     if (devm_thermal_add_hwmon_sysfs(&pdev->dev, gti->tz_dev))
> > +             dev_warn(&pdev->dev, "Failed to add hwmon sysfs attributes\n");
>
> Isn't that already done by patch 1/12?

I think patch 12 should just be squashed in?

> Regards,
> Matthias
>
> > +
> >       return 0;
> >   }
> >