linux-kernel - Re: [PATCHv3 2/2] arm64: dts: rockchip: add dts for Firefly Station P2 aka rk3568-roc-pc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1687280004029.3690769854.982412891@manjaro.org>
Date:   Tue, 20 Jun 2023 17:05:48 +0000
From:   Furkan Kardame <f.kardame@...jaro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        robh+dt@...nel.org
Cc:     krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        heiko@...ech.de, broonie@...nel.org, deller@....de,
        dsterba@...e.com, arnd@...db.de, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv3 2/2] arm64: dts: rockchip: add dts for Firefly
 Station P2 aka rk3568-roc-pc




On Tuesday 20 June 2023 09:19:22 (+03:00), Krzysztof Kozlowski wrote:

> On 19/06/2023 20:48, Furkan Kardame wrote:
> > Add dts for Firefly Station P2.
> > Working IO:
> > * eMMC
> > * HDMI
> > * LAN
> > * LED
> > * SD Card
> > * UART
> > * USB2
> > * USB3
> ...
> 
> > +	};
> > +
> > +	hdmi-con {
> > +		compatible = "hdmi-connector";
> > +		type = "a";
> > +
> > +		port {
> > +			hdmi_con_in: endpoint {
> > +			remote-endpoint = <&hdmi_out_con>;
> 
> Missing indentation.

I am not able to see any missing indentation in the patch. 
I did run checkpatch and did not find any such warning.
Please advice in detail ?


> 
> ...
> 
> > +
> > +	vcc3v3_lcd0_n: vcc3v3-lcd0-n-regulator {
> > +		compatible = "regulator-fixed";
> > +		regulator-name = "vcc3v3_lcd0_n";
> > +		regulator-boot-on;
> > +
> > +		regulator-state-mem {
> > +			regulator-off-in-suspend;
> 
> How do you turn this regulator off in suspend?

These nodes needs to be deleted as they are not used.
I will remove vcc3v3_lcd0_n and send a new patch.

> 
> > +		};
> > +	};
> > +
> > +	vcc3v3_lcd1_n: vcc3v3-lcd1-n-regulator {
> > +		compatible = "regulator-fixed";
> > +		regulator-name = "vcc3v3_lcd1_n";
> > +		regulator-boot-on;
> > +
> > +		regulator-state-mem {
> > +			regulator-off-in-suspend;
> 
> Same question here.
vcc3v3_lcd1_n will be removed.
> 
> > +		};
> > +	};
> > +};
> 
> 
> 
> Best regards,
> Krzysztof
> 
> 

-- 
-- 
With best regards
Furkan Kardame