linux-kernel - Re: [PATCH] ACPI: APEI: mark some functions _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 20 Jun 2023 11:43:29 +0800
From:   Shuai Xue <xueshuai@...ux.alibaba.com>
To:     Miaohe Lin <linmiaohe@...wei.com>, rafael@...nel.org
Cc:     lenb@...nel.org, james.morse@....com, tony.luck@...el.com,
        bp@...en8.de, linux-acpi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ACPI: APEI: mark some functions __init



On 2023/6/17 16:07, Miaohe Lin wrote:
> hest_esrc_len() and apei_hest_parse() are only called inside __init
> section. So mark them __init too.

Hi, Miaohe,

should ghes_estatus_pool_init also be marked with __init?

Thanks.

Best Regards,
Shuai


> 
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
> ---
>  drivers/acpi/apei/hest.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/acpi/apei/hest.c b/drivers/acpi/apei/hest.c
> index 6aef1ee5e1bd..2d78e808ab8b 100644
> --- a/drivers/acpi/apei/hest.c
> +++ b/drivers/acpi/apei/hest.c
> @@ -55,7 +55,7 @@ static inline bool is_generic_error(struct acpi_hest_header *hest_hdr)
>  	       hest_hdr->type == ACPI_HEST_TYPE_GENERIC_ERROR_V2;
>  }
>  
> -static int hest_esrc_len(struct acpi_hest_header *hest_hdr)
> +static int __init hest_esrc_len(struct acpi_hest_header *hest_hdr)
>  {
>  	u16 hest_type = hest_hdr->type;
>  	int len;
> @@ -88,7 +88,7 @@ static int hest_esrc_len(struct acpi_hest_header *hest_hdr)
>  
>  typedef int (*apei_hest_func_t)(struct acpi_hest_header *hest_hdr, void *data);
>  
> -static int apei_hest_parse(apei_hest_func_t func, void *data)
> +static int __init apei_hest_parse(apei_hest_func_t func, void *data)
>  {
>  	struct acpi_hest_header *hest_hdr;
>  	int i, rc, len;