linux-kernel - Re: [PATCH v2] tracing/boot: Replace strlcpy with strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202306201335.D6D772A@keescook>
Date:   Tue, 20 Jun 2023 13:35:14 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     mhiramat@...nel.org, ebiggers@...nel.org, azeemshaikh38@...il.com,
        linux-trace-kernel@...r.kernel.org,
        linux-hardening@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] tracing/boot: Replace strlcpy with strscpy

On Tue, Jun 20, 2023 at 04:33:25PM -0400, Steven Rostedt wrote:
> On Tue, 20 Jun 2023 13:28:26 -0700
> Kees Cook <keescook@...omium.org> wrote:
> 
> > On Thu, 15 Jun 2023 18:04:20 +0000, Azeem Shaikh wrote:
> > > strlcpy() reads the entire source buffer first.
> > > This read may exceed the destination size limit.
> > > This is both inefficient and can lead to linear read
> > > overflows if a source string is not NUL-terminated [1].
> > > In an effort to remove strlcpy() completely [2], replace
> > > strlcpy() here with strscpy().
> > > 
> > > [...]  
> > 
> > Applied to for-next/hardening, thanks!
> > 
> > [1/1] tracing/boot: Replace strlcpy with strscpy
> >       https://git.kernel.org/kees/c/b1c38314f756
> > 
> 
> I was going to add this to my queue.

Ah, okay, no worries. I will drop it from mine.

-- 
Kees Cook