[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZJEvi8CJddmpeluC@infradead.org>
Date: Mon, 19 Jun 2023 21:48:11 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Bean Huo <beanhuo@...pp.de>
Cc: viro@...iv.linux.org.uk, brauner@...nel.org,
akpm@...ux-foundation.org, jack@...e.cz, jack@...e.com,
tytso@....edu, adilger.kernel@...ger.ca, mark@...heh.com,
jlbec@...lplan.org, joseph.qi@...ux.alibaba.com,
linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org,
linux-kernel@...r.kernel.org, ocfs2-devel@....oracle.com,
beanhuo@...ron.com
Subject: Re: [PATCH v2 2/5] ext4: No need to check return value of
block_commit_write()
On Mon, Jun 19, 2023 at 11:18:24PM +0200, Bean Huo wrote:
> From: Bean Huo <beanhuo@...ron.com>
>
> Remove unnecessary check on the return value of block_commit_write(),
> because it always returns 0.
Dropping the error check before the function signature is changes is
really odd. I'd suggest to merge this and the following patches into
a single one.
Powered by blists - more mailing lists