linux-kernel - Re: [PATCH] USB: serial-simple: adding Kaufmann RKS+CAN VCP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZJFDvJh6TRJhyKFe@hovoldconsulting.com>
Date:   Tue, 20 Jun 2023 08:14:20 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Oliver Neukum <oneukum@...e.com>
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Kaufmann Automotive GmbH <info@...fmann-automotive.ch>
Subject: Re: [PATCH] USB: serial-simple: adding Kaufmann RKS+CAN VCP

On Tue, Jun 13, 2023 at 11:33:51AM +0200, Oliver Neukum wrote:
> Adding the device and product ID

Can you say something more about the product here (e.g. to indicate that
this is indeed a custom firmware that requires a simple driver)?

> Reported-by: Kaufmann Automotive GmbH <info@...fmann-automotive.ch>
> Tested-by: Kaufmann Automotive GmbH <info@...fmann-automotive.ch>
> Signed-off-by: Oliver Neukum <oneukum@...e.com>
> ---
>  drivers/usb/serial/usb-serial-simple.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/usb/serial/usb-serial-simple.c b/drivers/usb/serial/usb-serial-simple.c
> index 4c6747889a19..3612031030bb 100644
> --- a/drivers/usb/serial/usb-serial-simple.c
> +++ b/drivers/usb/serial/usb-serial-simple.c
> @@ -117,6 +117,11 @@ DEVICE(suunto, SUUNTO_IDS);
>  	{ USB_DEVICE(0x908, 0x0004) }
>  DEVICE(siemens_mpi, SIEMENS_IDS);
>  
> +/* KAUFMANN RKS+CAN VCP */
> +#define KAUFMANN_IDS()			\
> +	{ USB_DEVICE(0x16d0, 0x0870) }
> +DEVICE(kaufmann, KAUFMANN_IDS);

Can you add this one after GOOGLE_IDS() to approximate some ordering?

I'll try to move the rest in place later.

> +
>  /* All of the above structures mushed into two lists */
>  static struct usb_serial_driver * const serial_drivers[] = {
>  	&carelink_device,
> @@ -133,6 +138,7 @@ static struct usb_serial_driver * const serial_drivers[] = {
>  	&hp4x_device,
>  	&suunto_device,
>  	&siemens_mpi_device,
> +	&kaufmann_device,
>  	NULL
>  };
>  
> @@ -151,6 +157,7 @@ static const struct usb_device_id id_table[] = {
>  	HP4X_IDS(),
>  	SUUNTO_IDS(),
>  	SIEMENS_IDS(),
> +	KAUFMANN_IDS(),
>  	{ },
>  };

Similar in these two arrays.

Johan