linux-kernel - Re: [PATCH AUTOSEL 4.14 08/10] MIPS: Alchemy: fix dbdma2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOLZvyGhOpZ1NAfOKTOOq34Khh6nXAuLYVVB0DhLa4VRqsi-Vg@mail.gmail.com>
Date:   Tue, 20 Jun 2023 08:31:49 +0200
From:   Manuel Lauss <manuel.lauss@...il.com>
To:     Pavel Machek <pavel@...x.de>
Cc:     Sasha Levin <sashal@...nel.org>, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        linux-mips@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 4.14 08/10] MIPS: Alchemy: fix dbdma2

On Sun, Jun 18, 2023 at 10:56 AM Pavel Machek <pavel@...x.de> wrote:
>
> On Sun 2023-06-18 07:43:10, Manuel Lauss wrote:
> > On Fri, Jun 16, 2023 at 9:33 PM Pavel Machek <pavel@...x.de> wrote:
> >
> > > Hi!
> > >
> > > > From: Manuel Lauss <manuel.lauss@...il.com>
> > > >
> > > > [ Upstream commit 2d645604f69f3a772d58ead702f9a8e84ab2b342 ]
> > > >
> > > > Various fixes for the Au1200/Au1550/Au1300 DBDMA2 code:
> > > >
> > > > - skip cache invalidation if chip has working coherency circuitry.
> > > > - invalidate KSEG0-portion of the (physical) data address.
> > > > - force the dma channel doorbell write out to bus immediately with
> > > >   a sync.
> > > >
> > > > Signed-off-by: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
> > > > Signed-off-by: Sasha Levin <sashal@...nel.org>
> > >
> > > I believe author's signoff is missing here.
> > >
> >
> > As the author, I say this patch should not be applied to 4.xx at all.  Same
> > for my other 2 MIPS patches.
>
> Thanks for info, where is the threshold, do we need them for 5.10?

Drop this one "MIPS: Alchemy: fix dbdma2" from all stable,
the other 2 can be applied to 5.10 if need be.  I seem to be the only active
user of this hardware and I only test mainline, so it's probably not a big issue
if you drop the all from stable.

    Manuel