linux-kernel - Re: [PATCH net-next] net: dsa: microchip: ksz9477: follow errata sheet when applying fixups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <423d2a3c-6b4d-449f-5fa6-5402467e1b6e@rasmusvillemoes.dk>
Date:   Tue, 20 Jun 2023 09:15:39 +0200
From:   Rasmus Villemoes <linux@...musvillemoes.dk>
To:     Robert Hancock <robert.hancock@...ian.com>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "olteanv@...il.com" <olteanv@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "hancock@...systems.ca" <hancock@...systems.ca>,
        "woojung.huh@...rochip.com" <woojung.huh@...rochip.com>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>,
        "pabeni@...hat.com" <pabeni@...hat.com>
Cc:     "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] net: dsa: microchip: ksz9477: follow errata
 sheet when applying fixups

On 19/06/2023 19.31, Robert Hancock wrote:
> On Mon, 2023-06-19 at 10:16 +0200, Rasmus Villemoes wrote:
>>
>> Fixes: 1fc33199185d ("net: dsa: microchip: Add PHY errata
>> workarounds")
>> Cc: stable@...r.kernel.org
>> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>
>> ---
>> While I do believe this is a fix, I don't think it's post-rc7
>> material, hence targeting net-next with cc stable.
> 
> I don't think this will apply to net-next as the relevant code has been
> moved to the Micrel PHY driver and removed from this one in the
> following commits, 

Ah, sorry about that. This code hadn't been touched in a very long time,
so I didn't actually think to check -next.

and effectively the same change to disable autoneg
> before the register writes and re-enable afterwards was incorporated:

Yes, except it seems to always enable autoneg, even if the phy was
strapped otherwise. That's not a problem for our use case.

> However, your patch may be reasonable to apply to -rc7 or stable as a
> more targeted change for those releases.

Well, yes, it could be backported, but then there'd be a (simple)
conflict when net-next is to be merged in the next window. So I don't
think it's worth it.

Unless the net maintainers decide otherwise, please just drop this patch.

Rasmus