linux-kernel - Re: [PATCH v1 29/43] dt-bindings: rtc: Add ST M48T86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e6c68580df0bb8441bf5beabfa978bfe15e0a39d.camel@maquefel.me>
Date:   Tue, 20 Jun 2023 10:30:54 +0300
From:   Nikita Shubin <nikita.shubin@...uefel.me>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Alexander Sverdlin <alexander.sverdlin@...il.com>,
        Arnd Bergmann <arnd@...db.de>,
        Linus Walleij <linus.walleij@...aro.org>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc:     Michael Peters <mpeters@...eddedTS.com>,
        Kris Bahnsen <kris@...eddedTS.com>, linux-rtc@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 29/43] dt-bindings: rtc: Add ST M48T86

Hello Krzysztof!

On Thu, 2023-06-01 at 10:18 +0200, Krzysztof Kozlowski wrote:
> On 01/06/2023 07:45, Nikita Shubin wrote:
> > Add YAML bindings for ST M48T86 / Dallas DS12887 RTC.
> > 
> > Signed-off-by: Nikita Shubin <nikita.shubin@...uefel.me>
> > ---
> > 
> > Notes:
> >     v0 -> v1:
> >     
> >     - s/dallas/st/
> >     - description for regs
> >     - s/additionalProperties/unevaluatedProperties/
> >     - add ref rtc.yaml
> >     - changed compatible to st,m48t86
> >     - dropped label in example
> >     - replaced Alessandro Alessandro to Alexandre Belloni
> > 
> >  .../bindings/rtc/st,m48t86-rtc.yaml           | 38
> > +++++++++++++++++++
> >  1 file changed, 38 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/rtc/st,m48t86-rtc.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/rtc/st,m48t86-
> > rtc.yaml b/Documentation/devicetree/bindings/rtc/st,m48t86-rtc.yaml
> > new file mode 100644
> > index 000000000000..eb8e6451d7c8
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/rtc/st,m48t86-rtc.yaml
> 
> Filename based on compatible, so drop "rtc".
> 
> > @@ -0,0 +1,38 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/rtc/st,m48t86-rtc.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: ST M48T86 / Dallas DS12887 RTC wirh SRAM
> 
> typo: with
> 
> > +
> > +maintainers:
> > +  - Alexandre Belloni <alexandre.belloni@...tlin.com>
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - st,m48t86
> > +
> > +  reg:
> > +    items:
> > +      - description: index register
> > +      - description: data register
> > +
> > +allOf:
> > +  - $ref: rtc.yaml
> > +
> > +unevaluatedProperties: false
> > +
> > +required:
> > +  - compatible
> > +  - reg
> 
> required goes after properties:
> 
> Keep the same order in all your patches.
> 
> > +
> > +examples:
> > +  - |
> > +    rtc@...00000 {
> > +      compatible = "st,m48t86";
> > +      reg = <0x10800000 0x1>, <0x11700000 0x1>;
> 
> One byte long? Not a word?

They are indeed one byte long:

https://elixir.bootlin.com/linux/v6.4-rc7/source/drivers/rtc/rtc-m48t86.c#L46

> 
> > +    };
> > +
> > +...
> 
> Best regards,
> Krzysztof
>