linux-kernel - [PATCH] selftests/input: add test to cover failure on dev->absinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 20 Jun 2023 10:56:45 +0300
From:   Dana Elfassy <delfassy@...hat.com>
To:     shuah@...nel.org, eballetbo@...nel.org, usama.anjum@...labora.com,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Dana Elfassy <dangel101@...il.com>
Subject: [PATCH] selftests/input: add test to cover failure on dev->absinfo

Added coverage for the case where !dev->absinfo, and executing the
normal flow as well.

Signed-off-by: Dana Elfassy <dangel101@...il.com>
---
This patch depends on '[v3] selftests/input: Introduce basic tests for evdev ioctls' [1] sent to the ML.
[1] https://patchwork.kernel.org/project/linux-input/patch/20230607153214.15933-1-eballetbo@kernel.org/ 

 tools/testing/selftests/input/evioc-test.c | 23 ++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/tools/testing/selftests/input/evioc-test.c b/tools/testing/selftests/input/evioc-test.c
index ad7b93fe39cf..1a688002e1e7 100644
--- a/tools/testing/selftests/input/evioc-test.c
+++ b/tools/testing/selftests/input/evioc-test.c
@@ -234,4 +234,27 @@ TEST(eviocsrep_set_repeat_settings)
 	selftest_uinput_destroy(uidev);
 }
 
+TEST(eviocsabs_set_abs_value_limits)
+{
+	struct selftest_uinput *uidev;
+	struct input_absinfo absinfo;
+	int rc;
+
+	// fail test on dev->absinfo
+	rc = selftest_uinput_create_device(&uidev);
+	ASSERT_EQ(0, rc);
+	ASSERT_NE(NULL, uidev);
+	rc = ioctl(uidev->evdev_fd, EVIOCSABS(0), &absinfo);
+	ASSERT_EQ(-1, rc);
+	selftest_uinput_destroy(uidev);
+
+	// ioctl normal flow
+	rc = selftest_uinput_create_device(&uidev, EV_ABS, -1);
+	ASSERT_EQ(0, rc);
+	ASSERT_NE(NULL, uidev);
+	rc = ioctl(uidev->evdev_fd, EVIOCSABS(0), &absinfo);
+	ASSERT_EQ(0, rc);
+	selftest_uinput_destroy(uidev);
+}
+
 TEST_HARNESS_MAIN
-- 
2.41.0