linux-kernel - RE: [PATCH v4 5/5] dt-bindings: phy: realtek: Add the doc about the Realtek SoC USB 3.0 PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <79731b2216f24df9b2db0bc8795b26bb@realtek.com>
Date:   Tue, 20 Jun 2023 09:00:56 +0000
From:   Stanley Chang[昌育德] 
        <stanley_chang@...ltek.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Vinod Koul <vkoul@...nel.org>,
        Kishon Vijay Abraham I <kishon@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Alan Stern <stern@...land.harvard.edu>,
        Flavio Suligoi <f.suligoi@...m.it>,
        Bagas Sanjaya <bagasdotme@...il.com>,
        Matthias Kaehlcke <mka@...omium.org>,
        Ray Chi <raychi@...gle.com>,
        "linux-phy@...ts.infradead.org" <linux-phy@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>
Subject: RE: [PATCH v4 5/5] dt-bindings: phy: realtek: Add the doc about the Realtek SoC USB 3.0 PHY

Hi Krzysztof,

> > +properties:
> > +  compatible:
> > +    items:
> > +      - enum:
> > +          - realtek,rtd1295-usb3phy
> > +          - realtek,rtd1319-usb3phy
> > +          - realtek,rtd1319d-usb3phy
> > +          - realtek,rtd1619-usb3phy
> > +          - realtek,rtd1619b-usb3phy
> > +      - const: realtek,usb3phy
> 
> Drop last compatible, it is not used now. Does not make sense.

Okay. I will remove it.

> > +
> > +  reg:
> > +    description: PHY data registers
> 
> Drop description, it's obvious.

Okay.

> > +    maxItems: 1
> > +
> > +  "#phy-cells":
> > +    const: 0
> > +
> > +  nvmem-cells:
> > +    maxItems: 1
> > +    description: A phandle to the tx lfps swing trim data provided by
> > +      a nvmem device, if unspecified, default values shall be used.
> > +
> > +  nvmem-cell-names:
> > +    items:
> > +      - const: usb_u3_tx_lfps_swing_trim
> > +
> > +  realtek,amplitude-control-coarse-tuning:
> > +    description:
> > +      This adjusts the signal amplitude for normal operation and beacon
> LFPS.
> > +      This value is a parameter for coarse tuning.
> > +      For different boards, if the default value is inappropriate, this
> > +      property can be assigned to adjust.
> 
> default:

I will add it.

> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    minimum: 0
> > +    maximum: 255
> > +
> > +  realtek,amplitude-control-fine-tuning:
> > +    description:
> > +      This adjusts the signal amplitude for normal operation and beacon
> LFPS.
> > +      This value is used for fine-tuning parameters.
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> 
> default:

I will add it.

> > +    minimum: 0
> > +    maximum: 65535
> > +
> 

Thanks,
Stanley