[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20230620090732.50025-1-frank.li@vivo.com>
Date: Tue, 20 Jun 2023 17:07:22 +0800
From: Yangtao Li <frank.li@...o.com>
To: glaroque@...libre.com, rafael@...nel.org,
daniel.lezcano@...aro.org, amitk@...nel.org, rui.zhang@...el.com,
shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
festevam@...il.com, linux-imx@....com, agross@...nel.org,
andersson@...nel.org, konrad.dybcio@...aro.org,
thara.gopinath@...il.com, anarsoul@...il.com,
tiny.windzz@...il.com, wens@...e.org, jernej.skrabec@...il.com,
samuel@...lland.org, thierry.reding@...il.com,
jonathanh@...dia.com, edubezval@...il.com, j-keerthy@...com,
matthias.bgg@...il.com, angelogioacchino.delregno@...labora.com,
bchihi@...libre.com, f.fainelli@...il.com,
niklas.soderlund+renesas@...natech.se
Cc: linux-pm@...r.kernel.org, linux-amlogic@...ts.infradead.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-arm-msm@...r.kernel.org, linux-sunxi@...ts.linux.dev,
linux-tegra@...r.kernel.org, linux-omap@...r.kernel.org,
linux-mediatek@...ts.infradead.org, Yangtao Li <frank.li@...o.com>
Subject: [PATCH v4 01/11] thermal/hwmon: Add error information printing for devm_thermal_add_hwmon_sysfs()
Ensure that all error handling branches print error information. In this
way, when this function fails, the upper-layer functions can directly
return an error code without missing debugging information. Otherwise,
the error message will be printed redundantly or missing.
Signed-off-by: Yangtao Li <frank.li@...o.com>
---
v4:
-merge two generic-adc patch into one
v3:
-cleanup lvts_thermal
v2:
-convert to dev_warn
drivers/thermal/thermal_hwmon.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/thermal/thermal_hwmon.c b/drivers/thermal/thermal_hwmon.c
index fbe55509e307..c3ae44659b81 100644
--- a/drivers/thermal/thermal_hwmon.c
+++ b/drivers/thermal/thermal_hwmon.c
@@ -271,11 +271,14 @@ int devm_thermal_add_hwmon_sysfs(struct device *dev, struct thermal_zone_device
ptr = devres_alloc(devm_thermal_hwmon_release, sizeof(*ptr),
GFP_KERNEL);
- if (!ptr)
+ if (!ptr) {
+ dev_warn(dev, "Failed to allocate device resource data\n");
return -ENOMEM;
+ }
ret = thermal_add_hwmon_sysfs(tz);
if (ret) {
+ dev_warn(dev, "Failed to add hwmon sysfs attributes\n");
devres_free(ptr);
return ret;
}
--
2.39.0
Powered by blists - more mailing lists