linux-kernel - Re: [PATCH] dt-bindings: timer: add Ralink SoCs timer documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 20 Jun 2023 11:40:21 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Sergio Paracuellos <sergio.paracuellos@...il.com>,
        devicetree@...r.kernel.org
Cc:     daniel.lezcano@...aro.org, tglx@...utronix.de, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: timer: add Ralink SoCs timer documentation

On 20/06/2023 11:34, Sergio Paracuellos wrote:
> Add YAML documentation for the timer which is present on Ralink SoCs.

If there is going to be new version:
A nit, subject: drop second/last, redundant "documentation". The
"dt-bindings" prefix is already stating that these are bindings in
documentation.

> 
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@...il.com>
> ---
>  .../bindings/timer/ralink,rt2880-timer.yaml   | 49 +++++++++++++++++++
>  1 file changed, 49 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/timer/ralink,rt2880-timer.yaml
> 
> diff --git a/Documentation/devicetree/bindings/timer/ralink,rt2880-timer.yaml b/Documentation/devicetree/bindings/timer/ralink,rt2880-timer.yaml
> new file mode 100644
> index 000000000000..9a315449f73e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/timer/ralink,rt2880-timer.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/timer/ralink,rt2880-timer.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Timer present in Ralink family SoCs
> +
> +maintainers:
> +  - Sergio Paracuellos <sergio.paracuellos@...il.com>
> +
> +properties:
> +  compatible:
> +    const: ralink,rt2880-timer
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  clock-names:
> +    const: timer

Names matching the module name are not really helpful, so drop it,
unless any existing user needs it.

> +
> +  interrupts:
> +    maxItems: 1
> +

Best regards,
Krzysztof