linux-kernel - Re: [PATCH] dt-bindings: timer: add Ralink SoCs timer documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f068e601-52ec-2dbf-d117-4164863d58ab@linaro.org>
Date:   Tue, 20 Jun 2023 11:57:37 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Sergio Paracuellos <sergio.paracuellos@...il.com>
Cc:     devicetree@...r.kernel.org, daniel.lezcano@...aro.org,
        tglx@...utronix.de, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: timer: add Ralink SoCs timer documentation

On 20/06/2023 11:51, Sergio Paracuellos wrote:
>>> +  reg:
>>> +    maxItems: 1
>>> +
>>> +  clocks:
>>> +    maxItems: 1
>>> +
>>> +  clock-names:
>>> +    const: timer
>>
>> Names matching the module name are not really helpful, so drop it,
>> unless any existing user needs it.
> 
> I am ok with dropping this. If you meant with an existing user
> something that is already mainlined in the kernel tree then I would

Yes.

> say there is no need for this 'clock-names'. I don't know about other
> places since these SoCs are pretty old and almost with nothing
> documented. I am doing the effort of trying to document all the stuff
> before porting some openWRT device tree files to the kernel (this
> timer driver is already included in 'arch/mips/ralink' so I am
> documenting already in-tree things). So I guess I should send v2
> removing this?

Yes, please.

Best regards,
Krzysztof