linux-kernel - Re: [PATCH 1/1] vmgenid: emit uevent when VMGENID updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ad46e3e2-20f0-2384-0bde-37fa856e9eb1@amazon.es>
Date:   Tue, 20 Jun 2023 12:27:27 +0200
From:   Babis Chalios <bchalios@...zon.es>
To:     "Jason A. Donenfeld" <Jason@...c4.com>
CC:     Theodore Ts'o <tytso@....edu>, <linux-kernel@...r.kernel.org>,
        <graf@...zon.de>, <mzxreary@...inter.de>, <xmarcalx@...zon.co.uk>
Subject: Re: [PATCH 1/1] vmgenid: emit uevent when VMGENID updates

Hi Jason,

On 19/6/23 22:30, Jason A. Donenfeld wrote:
> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
>
>
>
> Like the other patch, and as discussed before too, I don't think this
> has any business being part of (virtual) hardware drivers, and instead
> belongs in random.c, which might receive these notifications from a
> variety of devices, and can thus synchronize things accordingly.
> Please stop posting more of these same approaches. Same nack as the
> other ones.

Quoting the cover letter of this patchset

> Please note, that this is not a "you need to reseed your PRNGs" event,
> which was what the previous RFC [1] was trying to do. It is, explicitly,
> meant to be a "you are now running in a new VM" event for the user space
> to consume, so it can do things like regenerating its MAC addresses and
> refreshing DHCP.

Why do you think that the "you are now running in a new VM" event (that has
nothing to do with PRNGs) belongs in random.c?

Cheers,
Babis