linux-kernel - Re: [RFC PATCH v2 3/3] arm64: dts: renesas: ulcb-kf: add node for GPS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdXbpBeKNL6QC_vYTrocf7xPcvUBQmoV9vboqVt_ciio+g@mail.gmail.com>
Date:   Tue, 20 Jun 2023 13:24:53 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc:     linux-renesas-soc@...r.kernel.org, Johan Hovold <johan@...nel.org>,
        Wolfram Sang <wsa@...nel.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Magnus Damm <magnus.damm@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH v2 3/3] arm64: dts: renesas: ulcb-kf: add node for GPS

Hi Wolfram,

On Tue, Jun 20, 2023 at 12:39 PM Wolfram Sang
<wsa+renesas@...g-engineering.com> wrote:
> From: Wolfram Sang <wsa@...nel.org>
>
> Add the node for the GPS receiver and its VCC supply.
>
> Signed-off-by: Wolfram Sang <wsa@...nel.org>
> ---
> Changes since RFC v1:
> * rebased because of patches dropped and refactored
> * added static vcc-suplly

Thanks for the update!

> @Geert: Not sure if we need so many fixed 3v3 regulators. Most of the
> other ones more or less directly derive from d_3v3. Or do you prefer it
> this way?

Probably all of them should refer to &reg_3p3v instead...

> --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> @@ -39,6 +39,13 @@ accel_3v3: regulator-acc-3v3 {
>                 regulator-max-microvolt = <3300000>;
>         };
>
> +       d_3v3: regulator-d-3v3 {

... but if you want to keep it like this for now, please name
it appropriately (s/d/gnss/g).

> +               compatible = "regulator-fixed";
> +               regulator-name = "d-3v3";
> +               regulator-min-microvolt = <3300000>;
> +               regulator-max-microvolt = <3300000>;
> +       };
> +
>         hdmi_1v8: regulator-hdmi-1v8 {
>                 compatible = "regulator-fixed";
>                 regulator-name = "hdmi-1v8";

The rest LGTM.

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds