linux-kernel - Re: [PATCH AUTOSEL 6.1 07/16] smb3: missing null check in SMB2_change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZJG7QRnLpnA17OVU@sashalap>
Date:   Tue, 20 Jun 2023 10:44:17 -0400
From:   Sasha Levin <sashal@...nel.org>
To:     Pavel Machek <pavel@...x.de>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Steve French <stfrench@...rosoft.com>,
        kernel test robot <lkp@...el.com>,
        Dan Carpenter <error27@...il.com>, pc@....nz, pc@...guebit.com,
        ematsumiya@...e.de, lsahlber@...hat.com, sprasad@...rosoft.com,
        vl@...ba.org, metze@...ba.org
Subject: Re: [PATCH AUTOSEL 6.1 07/16] smb3: missing null check in
 SMB2_change_notify

On Fri, Jun 16, 2023 at 09:39:28PM +0200, Pavel Machek wrote:
>Hi!
>
>> From: Steve French <stfrench@...rosoft.com>
>>
>> [ Upstream commit b535cc796a4b4942cd189652588e8d37c1f5925a ]
>>
>> If plen is null when passed in, we only checked for null
>> in one of the two places where it could be used. Although
>> plen is always valid (not null) for current callers of the
>> SMB2_change_notify function, this change makes it more consistent.
>
>Changelog explains problem can not happen, so... is this important
>enough to backport?

Have you confirmed whether it's indeed the case on all the trees we
support?

-- 
Thanks,
Sasha