linux-kernel - Re: [PATCH v2 2/3] usb: misc: onboard-hub: add support for Cypress HX3 USB 3.0 family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZJMQvpOYp1zagtE2@google.com>
Date:   Wed, 21 Jun 2023 15:01:18 +0000
From:   Matthias Kaehlcke <mka@...omium.org>
To:     Benjamin Bara <bbara93@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Benjamin Bara <benjamin.bara@...data.com>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v2 2/3] usb: misc: onboard-hub: add support for Cypress
 HX3 USB 3.0 family

On Wed, Jun 21, 2023 at 04:26:28PM +0200, Benjamin Bara wrote:
> From: Benjamin Bara <benjamin.bara@...data.com>
> 
> The HX3 comes in different variants (up to 4 USB 3.0 ports; multi-TT),
> e.g. CYUSB330x/CYUSB331x/CYUSB332x/CYUSB230x. It operates with two
> different power supplies: 1V2 and 3V3.
> 
> Add the support for this hub, for controlling the reset pin and the
> power supplies.
> 
> Reset time is extracted from data sheet, page 24:
> "The RESETN pin can be tied to VDD_IO through an external resistor and
> to ground (GND) through an external capacitor (minimum 5 ms time
> constant)."
> V_IH min is given at 0.7 * 3V3 (page 34), therefore use 10ms.
> 
> Also add USB PIDs for the USB 2.0 and USB 3.0 root hub.
> 
> Signed-off-by: Benjamin Bara <benjamin.bara@...data.com>

Acked-by: Matthias Kaehlcke <mka@...omium.org>