linux-kernel - Re: [PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 21 Jun 2023 16:03:02 +0100
From:   Lee Jones <lee@...nel.org>
To:     Raymond Hackley <raymondhackley@...tonmail.com>
Cc:     linux-kernel@...r.kernel.org, Pavel Machek <pavel@....cz>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Luca Weiss <luca@...tu.xyz>,
        "open list:LED SUBSYSTEM" <linux-leds@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033
 compatible

On Wed, 21 Jun 2023, Lee Jones wrote:

> On Fri, 02 Jun 2023, Raymond Hackley wrote:
> 
> > Add devicetree binding for Richtek RT5033 Flash LED charge pump used for
> > camera flash LEDs.
> > 
> > Signed-off-by: Raymond Hackley <raymondhackley@...tonmail.com>
> > ---
> >  Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > index 4d2ffe5fcfc7..37d2a93780ab 100644
> > --- a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > +++ b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > @@ -20,6 +20,7 @@ properties:
> >    compatible:
> >      enum:
> >        - ocs,ocp8110
> > +      - richtek,rt5033-led
> 
> Why is "-led" appended on to this one and not the others?

It's unusual for me to have to dump through a bunch of hoops just to
read and then subsequently reply to mail.  Can you consider removing
whatever encryption you have enabled please?

-- 
Lee Jones [李琼斯]