linux-kernel - Re: [PATCH] docs: trace: Convert decode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 21 Jun 2023 09:14:34 -0600
From:   Jonathan Corbet <corbet@....net>
To:     Rong Tao <rtoax@...mail.com>
Cc:     rongtao@...tc.cn,
        "open list:DOCUMENTATION" <linux-doc@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH] docs: trace: Convert decode_msr.py print syntax to python3

[Adding Andi]

Rong Tao <rtoax@...mail.com> writes:

> From: Rong Tao <rongtao@...tc.cn>
>
> Convert the decode_msr.py file to python3 to solve the following running
> errors:
>
>     File "Documentation/trace/postprocess/decode_msr.py", line 35
>         print j,
>              ^
>     SyntaxError: Missing parentheses in call to 'print'. Did you mean
>     print(j, end=" ")?
>
> Signed-off-by: Rong Tao <rongtao@...tc.cn>
> ---
>  Documentation/trace/postprocess/decode_msr.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/trace/postprocess/decode_msr.py b/Documentation/trace/postprocess/decode_msr.py
> index aa9cc7abd5c2..2d45d6c14987 100644
> --- a/Documentation/trace/postprocess/decode_msr.py
> +++ b/Documentation/trace/postprocess/decode_msr.py
> @@ -32,6 +32,6 @@ for j in sys.stdin:
>  					break
>  		if r:
>  			j = j.replace(" " + m.group(2), " " + r + "(" + m.group(2) + ")")
> -	print j,
> +	print(j + ",")

So I certainly have no problem applying this.  But it occurs to me that
this file hasn't been touched since it was added in 2015, and nobody has
complained that it doesn't work with modern Python.  That leads me to
wonder if it's being used at all.

Assuming that there is value in keeping it, I wonder if a move to
samples/ might make sense?

Thanks,

jon