linux-kernel - Re: [LTP] [linux-next:master] [scsi] eca2040972: ltp.ioprio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZJMYP/CCVviG6IMq@x1-carbon>
Date:   Wed, 21 Jun 2023 15:33:22 +0000
From:   Niklas Cassel <Niklas.Cassel@....com>
To:     Cyril Hrubis <chrubis@...e.cz>
CC:     Damien Le Moal <dlemoal@...nel.org>,
        kernel test robot <oliver.sang@...el.com>,
        "lkp@...el.com" <lkp@...el.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        Hannes Reinecke <hare@...e.de>,
        "oe-lkp@...ts.linux.dev" <oe-lkp@...ts.linux.dev>,
        Christoph Hellwig <hch@....de>,
        "ltp@...ts.linux.it" <ltp@...ts.linux.it>,
        Petr Vorel <pvorel@...e.cz>
Subject: Re: [LTP] [linux-next:master] [scsi] eca2040972:
 ltp.ioprio_set03.fail

On Wed, Jun 21, 2023 at 02:47:43PM +0200, Cyril Hrubis wrote:
> Hi!
> > > kernel test robot noticed "ltp.ioprio_set03.fail" on:
> > 
> > LTP maintainers,
> > 
> > Patches have been submitted to fix this issue. Were these patches applied ?
> 
> Looks like they are in, at least these two:
> 
>     ioprio: use ioprio.h kernel header if it exists
>     ioprio: Use IOPRIO_PRIO_NUM to check prio range
> 
> And there does not seem to be anything ioprio related haning in the LTP
> patchwork.

Hello Cyril, Petr, Damien,


I just ran LTP master + linux-next and the test case passes for me.


Although, note that even if you are using LTP master,
the way that the LTP header:
testcases/kernel/syscalls/ioprio/ioprio.h
is written, you will need to run

make headers_install
with linux-next kernel source,

before running
make autotools && ./configure
in LTP.

Otherwise LTP will use the kernel uapi headers from your distro,
which does not perform the new checks for the IOPRIO_PRIO_VALUE()
macro. (It requires linux uapi headers from linux-next.)



Does the linux kernel test robot not run
make headers_install
before running
make autotools && ./configure
in LTP?

One option, although I'm not sure if we want this,
is to change
testcases/kernel/syscalls/ioprio/ioprio.h
to do something like:

#ifndef IOPRIO_BAD_VALUE
# define IOPRIO_BAD_VALUE(val, max) ((val) < 0 || (val) >= (max))
#endif

such that LTP does not need to be compiled against the kernel uapi
headers that match the running kernel.

But... shouldn't the installed uapi headers match the running kernel?


Kind regards,
Niklas