linux-kernel - Re: [PATCH] docs: target: Convert tcm_mod

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <debdc47a-c377-e457-5643-415d93ced54a@acm.org>
Date:   Wed, 21 Jun 2023 08:41:58 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Rong Tao <rtoax@...mail.com>, martin.petersen@...cle.com
Cc:     rongtao@...tc.cn, Jonathan Corbet <corbet@....net>,
        "open list:SCSI TARGET SUBSYSTEM" <linux-scsi@...r.kernel.org>,
        "open list:SCSI TARGET SUBSYSTEM" <target-devel@...r.kernel.org>,
        "open list:DOCUMENTATION" <linux-doc@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        Mike Christie <michael.christie@...cle.com>
Subject: Re: [PATCH] docs: target: Convert tcm_mod_builder.py print syntax to
 python3

On 6/21/23 00:33, Rong Tao wrote:
> diff --git a/Documentation/target/tcm_mod_builder.py b/Documentation/target/tcm_mod_builder.py
> index 54492aa813b9..e2ef72925de3 100755
> --- a/Documentation/target/tcm_mod_builder.py
> +++ b/Documentation/target/tcm_mod_builder.py
> @@ -20,7 +20,7 @@ fabric_mod_port = ""
>   fabric_mod_init_port = ""
>   
>   def tcm_mod_err(msg):
> -	print msg
> +	print(msg)
>   	sys.exit(1)

How about deleting the file Documentation/target/tcm_mod_builder.py? I
don't think anyone is using this script. Additionally, it takes effort
to keep this script in sync with the rest of the SCSI target code. I'm
not sure anyone is interested in maintaining this script.

Thanks,

Bart.