linux-kernel - Re: [PATCH v2 1/3] usb: misc: onboard-hub: support multiple power supplies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230621154505.2229794-1-bbara93@gmail.com>
Date:   Wed, 21 Jun 2023 17:45:05 +0200
From:   Benjamin Bara <bbara93@...il.com>
To:     mka@...omium.org
Cc:     bbara93@...il.com, benjamin.bara@...data.com, conor+dt@...nel.org,
        devicetree@...r.kernel.org, gregkh@...uxfoundation.org,
        krzysztof.kozlowski+dt@...aro.org, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org, robh+dt@...nel.org
Subject: Re: [PATCH v2 1/3] usb: misc: onboard-hub: support multiple power supplies

Hi,

thanks for the feedback!

On Wed, 21 Jun 2023 at 16:57, Matthias Kaehlcke <mka@...omium.org> wrote:
> On Wed, Jun 21, 2023 at 04:26:27PM +0200, Benjamin Bara wrote:
> > +     hub->supplies_num = 1;
> > +     if (hub->pdata->supplies_num > 1)
> > +             hub->supplies_num = hub->pdata->supplies_num;
>
> Please change the above to:
>
>         if (hub->pdata->supplies_num != 0)
>                 hub->supplies_num = hub->pdata->supplies_num;
>         else
>                 hub->supplies_num = 1;
>

I would even prefer:
if (hub->pdata->supplies_num)

if it's fine for you?