linux-kernel - Re: [PATCH v6 22/26] dt-bindings: devfreq: event: rockchip,dfi: Add rk3588 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230621-poach-amniotic-2eeb858356c8@spud>
Date:   Wed, 21 Jun 2023 17:12:20 +0100
From:   Conor Dooley <conor@...nel.org>
To:     Sascha Hauer <s.hauer@...gutronix.de>
Cc:     Mark Rutland <mark.rutland@....com>, devicetree@...r.kernel.org,
        Conor Dooley <conor+dt@...nel.org>,
        Heiko Stuebner <heiko@...ech.de>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-pm@...r.kernel.org, Robin Murphy <robin.murphy@....com>,
        linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        Sebastian Reichel <sebastian.reichel@...labora.com>,
        linux-rockchip@...ts.infradead.org,
        Kyungmin Park <kyungmin.park@...sung.com>,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        Michael Riesch <michael.riesch@...fvision.net>,
        kernel@...gutronix.de, Vincent Legoll <vincent.legoll@...il.com>,
        Will Deacon <will@...nel.org>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v6 22/26] dt-bindings: devfreq: event: rockchip,dfi: Add
 rk3588 support

On Wed, Jun 21, 2023 at 09:41:59AM +0200, Sascha Hauer wrote:
> On Fri, Jun 16, 2023 at 08:05:33PM +0100, Conor Dooley wrote:
> > On Fri, Jun 16, 2023 at 08:20:57AM +0200, Sascha Hauer wrote:
> > > This adds rockchip,rk3588-dfi to the list of compatibles. Unlike ealier
> > > SoCs the rk3588 has four interrupts (one for each channel) instead of
> > > only one, so increase the number of allowed interrupts to four.
> > > 
> > > Link: https://lore.kernel.org/r/20230524083153.2046084-23-s.hauer@pengutronix.de
> > 
> > It's unclear what the point of this link is.
> 
> The link was added automatically by b4. I re-applied the series from the
> last one I sent just to be sure that I base my work for the new series
> on the one I sent last time. I didn't remember that b4 adds these links,
> I should have disabled that option.

Ah, I see.

> > My comment still stands about whether only the new compatible should be
> > permitted to have more than one interrupt. I don't recall a response to
> > that question on the last version.
> 
> My personal take on this is that such additions make the bindings more
> readable by machines, but less by humans. That's why I don't have enough
> intrinsic motivation to make this change.

> Anyway, if you insist then I'll make it for the next round.

No, I don't insist. I just wanted to not be ignored.
Acked-by: Conor Dooley <conor.dooley@...rochip.com>

Cheers,
Conor.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)