linux-kernel - [RFC 3/5] i3c: show node when printing unsupported 10-bit i2c dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230621162005.473049-4-ben.dooks@codethink.co.uk>
Date:   Wed, 21 Jun 2023 17:20:03 +0100
From:   Ben Dooks <ben.dooks@...ethink.co.uk>
To:     linux-i3c@...ts.infradead.org, linux-kernel@...r.kernel.org,
        alexandre.belloni@...tlin.com
Cc:     Ben Dooks <ben.dooks@...ethink.co.uk>
Subject: [RFC 3/5] i3c: show node when printing unsupported 10-bit i2c dev

When an i2c device is errored due to not being supported, the OF node
is not show (unlike errors from of_i2c_get_board_info). Make the failed
node explict in the of_i3c_master_add_i2c_boardinfo() to aid in tracking
down incorrect entries in the device tree.

Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>
---
 drivers/i3c/master.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
index 6316f3fc914a..bc42669f5c6d 100644
--- a/drivers/i3c/master.c
+++ b/drivers/i3c/master.c
@@ -2023,7 +2023,7 @@ of_i3c_master_add_i2c_boardinfo(struct i3c_master_controller *master,
 	 * DEFSLVS command.
 	 */
 	if (boardinfo->base.flags & I2C_CLIENT_TEN) {
-		dev_err(dev, "I2C device with 10 bit address not supported.");
+		dev_err(dev, "%pOF: I2C device with 10 bit address not supported.", node);
 		return -ENOTSUPP;
 	}
 
-- 
2.40.1