linux-kernel - Re: [PATCH v3] perf stat: Add missing newline in pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM9d7cjqim4iyBKU1ob3uYXbycQTJ1f-XEL1fCQpiKDMirEuFQ@mail.gmail.com>
Date:   Wed, 21 Jun 2023 10:22:47 -0700
From:   Namhyung Kim <namhyung@...nel.org>
To:     Yang Jihong <yangjihong1@...wei.com>
Cc:     peterz@...radead.org, mingo@...hat.com, acme@...nel.org,
        mark.rutland@....com, alexander.shishkin@...ux.intel.com,
        jolsa@...nel.org, irogers@...gle.com, adrian.hunter@...el.com,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
        james.clark@....com
Subject: Re: [PATCH v3] perf stat: Add missing newline in pr_err messages

On Tue, Jun 13, 2023 at 7:16 PM Yang Jihong <yangjihong1@...wei.com> wrote:
>
> The newline is missing for error messages in add_default_attributes()
>
> Before:
>
>   # perf stat --topdown
>   Topdown requested but the topdown metric groups aren't present.
>   (See perf list the metric groups have names like TopdownL1)#
>
> After:
>
>   # perf stat --topdown
>   Topdown requested but the topdown metric groups aren't present.
>   (See perf list the metric groups have names like TopdownL1)
>   #
>
> In addition, perf_stat_init_aggr_mode() and perf_stat_init_aggr_mode_file()
> have the same problem, fixed by the way.
>
> Signed-off-by: Yang Jihong <yangjihong1@...wei.com>
> Acked-by: Ian Rogers <irogers@...gle.com>
> Reviewed-by: James Clark <james.clark@....com>

Applied to perf-tools-next, thanks!