linux-kernel - Re: [PATCH] perf parse: Add missing newline to pr_debug message in evsel__compute_group_pmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM9d7cit095kueUKgo+bq7hakam3DoTOs7sB5SGKXMEpiRViDg@mail.gmail.com>
Date:   Wed, 21 Jun 2023 10:25:23 -0700
From:   Namhyung Kim <namhyung@...nel.org>
To:     Yang Jihong <yangjihong1@...wei.com>
Cc:     peterz@...radead.org, mingo@...hat.com, acme@...nel.org,
        mark.rutland@....com, alexander.shishkin@...ux.intel.com,
        jolsa@...nel.org, irogers@...gle.com, adrian.hunter@...el.com,
        kan.liang@...ux.intel.com, linux-perf-users@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf parse: Add missing newline to pr_debug message in evsel__compute_group_pmu_name()

On Tue, Jun 20, 2023 at 1:32 PM Namhyung Kim <namhyung@...nel.org> wrote:
>
> Hello,
>
> On Thu, Jun 15, 2023 at 7:47 PM Yang Jihong <yangjihong1@...wei.com> wrote:
> >
> > The newline is missing for pr_debug message in
> > evsel__compute_group_pmu_name(), fix it.
> >
> > Before:
> >
> >   # perf --debug verbose=2 record -e cpu-clock true
> >   <SNIP>
> >   No PMU found for 'cycles:u'No PMU found for 'instructions:u'------------------------------------------------------------
> >   perf_event_attr:
> >     type                             1
> >     size                             136
> >     { sample_period, sample_freq }   4000
> >     sample_type                      IP|TID|TIME|PERIOD
> >     read_format                      ID|LOST
> >     disabled                         1
> >     inherit                          1
> >     mmap                             1
> >     comm                             1
> >     freq                             1
> >     enable_on_exec                   1
> >     task                             1
> >     sample_id_all                    1
> >     exclude_guest                    1
> >     mmap2                            1
> >     comm_exec                        1
> >     ksymbol                          1
> >     bpf_event                        1
> >   ------------------------------------------------------------
> >   <SNIP>
> >
> > After:
> >
> >   # perf --debug verbose=2 record -e cpu-clock true
> >   <SNIP>
> >   No PMU found for 'cycles:u'
> >   No PMU found for 'instructions:u'
> >   ------------------------------------------------------------
> >   perf_event_attr:
> >     type                             1
> >     size                             136
> >     { sample_period, sample_freq }   4000
> >     sample_type                      IP|TID|TIME|PERIOD
> >     read_format                      ID|LOST
> >     disabled                         1
> >     inherit                          1
> >     mmap                             1
> >     comm                             1
> >     freq                             1
> >     enable_on_exec                   1
> >     task                             1
> >     sample_id_all                    1
> >     exclude_guest                    1
> >     mmap2                            1
> >     comm_exec                        1
> >     ksymbol                          1
> >     bpf_event                        1
> >   ------------------------------------------------------------
> >   <SNIP>
> >
> > Signed-off-by: Yang Jihong <yangjihong1@...wei.com>
>
> Acked-by: Namhyung Kim <namhyung@...nel.org>

Applied to perf-tools-next, thanks!