linux-kernel - RE: [PATCH v3 1/3] ACPI: CPPC: Add definition for undefined FADT preferred PM profile value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 21 Jun 2023 04:23:45 +0000
From:   "Yuan, Perry" <Perry.Yuan@....com>
To:     "Limonciello, Mario" <Mario.Limonciello@....com>,
        "Rafael J . Wysocki" <rafael@...nel.org>
CC:     Len Brown <lenb@...nel.org>, "Huang, Ray" <Ray.Huang@....com>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "Shenoy, Gautham Ranjal" <gautham.shenoy@....com>,
        "Karny, Wyes" <Wyes.Karny@....com>,
        "Yuan, Perry" <Perry.Yuan@....com>
Subject: RE: [PATCH v3 1/3] ACPI: CPPC: Add definition for undefined FADT
 preferred PM profile value

[AMD Official Use Only - General]

> -----Original Message-----
> From: Limonciello, Mario <Mario.Limonciello@....com>
> Sent: Wednesday, June 21, 2023 1:25 AM
> To: Rafael J . Wysocki <rafael@...nel.org>
> Cc: Len Brown <lenb@...nel.org>; Huang, Ray <Ray.Huang@....com>;
> linux-acpi@...r.kernel.org; linux-kernel@...r.kernel.org; linux-
> pm@...r.kernel.org; Shenoy, Gautham Ranjal
> <gautham.shenoy@....com>; Karny, Wyes <Wyes.Karny@....com>;
> Yuan, Perry <Perry.Yuan@....com>; Limonciello, Mario
> <Mario.Limonciello@....com>
> Subject: [PATCH v3 1/3] ACPI: CPPC: Add definition for undefined FADT
> preferred PM profile value
>
> In the event a new preferred PM profile value is introduced it's best for code
> to be able to defensively guard against it so that the wrong settings don't get
> applied on a new system that uses this profile but ancient kernels.
>
> Acked-by: Huang Rui <ray.huang@....com>
> Suggested-by: Gautham Ranjal Shenoy <gautham.shenoy@....com>
> Link:
> https://uefi.org/htmlspecs/ACPI_Spec_6_4_html/05_ACPI_Software_Progr
> amming_Model/ACPI_Software_Programming_Model.html#fixed-acpi-
> description-table-fadt
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>
> ---
> v2->v3:
>  * Drop new symbols (they fold into patch 2)
>  * Update commit message
>  * Add Ray's tag
> ---
>  include/acpi/actbl.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/acpi/actbl.h b/include/acpi/actbl.h index
> e5dfb6f4de52..451f6276da49 100644
> --- a/include/acpi/actbl.h
> +++ b/include/acpi/actbl.h
> @@ -307,7 +307,8 @@ enum acpi_preferred_pm_profiles {
>       PM_SOHO_SERVER = 5,
>       PM_APPLIANCE_PC = 6,
>       PM_PERFORMANCE_SERVER = 7,
> -     PM_TABLET = 8
> +     PM_TABLET = 8,
> +     NR_PM_PROFILES = 9
>  };
>
>  /* Values for sleep_status and sleep_control registers (V5+ FADT) */
> --
> 2.34.1

LGTM,
Reviewed-by: Perry Yuan <Perry.Yuan@....com>