linux-kernel - Re: [PATCH v3] phy: cadence: Sierra: Add single link SGMII register configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZJM4iUrlMIVwlfK+@matsya>
Date:   Wed, 21 Jun 2023 23:21:05 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Marcin Wierzbicki <mawierzb@...co.com>
Cc:     Kishon Vijay Abraham I <kishon@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Swapnil Jakhade <sjakhade@...ence.com>,
        Roger Quadros <rogerq@...nel.org>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, linux-phy@...ts.infradead.org,
        linux-kernel@...r.kernel.org, xe-linux-external@...co.com,
        danielwa@...co.com, olicht@...co.com,
        Bartosz Wawrzyniak <bwawrzyn@...co.com>
Subject: Re: [PATCH v3] phy: cadence: Sierra: Add single link SGMII register
 configuration

On 21-06-23, 23:09, Vinod Koul wrote:
> On 22-05-23, 17:24, Marcin Wierzbicki wrote:
> > Add single link SGMII register configuration for no SSC for
> > cdns,sierra-phy-t0 compatibility string.
> > The configuration is based on Sierra Programmer's Guide and
> > validated in Cisco CrayAR SoC.
> 
> Applied, thanks

This breaks build for me, so dropped. This is with arm64 allmodconfig
and gcc-aarch4 toolchain

drivers/phy/cadence/phy-cadence-sierra.c:2556:32: error: initialized field overwritten [-Werror=override-init]
 2556 |                 [TYPE_SGMII] = {
      |                                ^
drivers/phy/cadence/phy-cadence-sierra.c:2556:32: note: (near initialization for ‘cdns_map_sierra.pma_cmn_vals[3]’)
drivers/phy/cadence/phy-cadence-sierra.c:2599:32: error: initialized field overwritten [-Werror=override-init]
 2599 |                 [TYPE_SGMII] = {
      |                                ^
drivers/phy/cadence/phy-cadence-sierra.c:2599:32: note: (near initialization for ‘cdns_map_sierra.pma_ln_vals[3]’)
cc1: all warnings being treated as errors

-- 
~Vinod