[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20230621175626.1229-1-raymondhackley@protonmail.com>
Date: Wed, 21 Jun 2023 17:56:40 +0000
From: Raymond Hackley <raymondhackley@...tonmail.com>
To: krzysztof.kozlowski@...aro.org
Cc: devicetree@...r.kernel.org, krzysztof.kozlowski+dt@...aro.org,
lee@...nel.org, linux-kernel@...r.kernel.org,
linux-leds@...r.kernel.org, luca@...tu.xyz, pavel@....cz,
raymondhackley@...tonmail.com, robh+dt@...nel.org,
~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [RESEND PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible
Hi Krzysztof,
On Sunday, June 4th, 2023 at 10:43 AM, Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> wrote:
> On 02/06/2023 15:38, Raymond Hackley wrote:
>
> > Add devicetree binding for Richtek RT5033 Flash LED charge pump used for
> > camera flash LEDs.
>
>
> What are the similarities? Same register interface? Same pins? It's not
> obvious and your commit should clear explain this. It will be also
> justification why you did not make devices compatible.
>
There is a similar way to control with 2 GPIO pins, strobe and enable,
which is not described well in this patch set.
Regards,
Raymond
Powered by blists - more mailing lists