linux-kernel - Re: [PATCH 2/2] scsi: bfa: fix function pointer type mismatch for state machines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <336f2156-220f-47ff-be97-5a2a9c475372@app.fastmail.com>
Date:   Wed, 21 Jun 2023 20:42:10 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Kees Cook" <keescook@...omium.org>,
        "Arnd Bergmann" <arnd@...nel.org>
Cc:     "Anil Gurumurthy" <anil.gurumurthy@...gic.com>,
        "Sudarsana Kalluru" <sudarsana.kalluru@...gic.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        "Azeem Shaikh" <azeemshaikh38@...il.com>,
        "Bjorn Helgaas" <bhelgaas@...gle.com>, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] scsi: bfa: fix function pointer type mismatch for state
 machines

On Wed, Jun 21, 2023, at 20:33, Kees Cook wrote:
> On Fri, Jun 16, 2023 at 11:22:10AM +0200, Arnd Bergmann wrote:
>> 
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>
> Thanks for all this! It's a lot of mechanical changes, but looks correct
> to me. One nit below...
>
> Reviewed-by: Kees Cook <keescook@...omium.org>
>
>> [...]
>>  static void
>> -bfad_sm_uninit(struct bfad_s *bfad, enum bfad_sm_event event);
>> +bfad_sm_uninit(struct bfad_s *bfad, enum bfad_sm_event);
>>  static void
>> -bfad_sm_created(struct bfad_s *bfad, enum bfad_sm_event event);
>> +bfad_sm_created(struct bfad_s *bfad, enum bfad_sm_event);
>>  static void
>> -bfad_sm_initializing(struct bfad_s *bfad, enum bfad_sm_event event);
>> +bfad_sm_initializing(struct bfad_s *bfad, enum bfad_sm_event);
>>  static void
>> -bfad_sm_operational(struct bfad_s *bfad, enum bfad_sm_event event);
>> +bfad_sm_operational(struct bfad_s *bfad, enum bfad_sm_event);
>>  static void
>> -bfad_sm_stopping(struct bfad_s *bfad, enum bfad_sm_event event);
>> +bfad_sm_stopping(struct bfad_s *bfad, enum bfad_sm_event);
>>  static void
>> -bfad_sm_failed(struct bfad_s *bfad, enum bfad_sm_event event);
>> +bfad_sm_failed(struct bfad_s *bfad, enum bfad_sm_event);
>>  static void
>> -bfad_sm_fcs_exit(struct bfad_s *bfad, enum bfad_sm_event event);
>> +bfad_sm_fcs_exit(struct bfad_s *bfad, enum bfad_sm_event);
>
> This bit doesn't seem needed? i.e. why remove the prototype's argument
> names?

Right, my mistake. I went through a few revisions and first tried to
change the prototypes here, but later changed them back. I missed
this after I folded my intermediate steps back into a single patch.

    Arnd