linux-kernel - Re: [PATCH][next] nfsd: remove redundant assignments to variable len

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <03b904b3c5981676dce8a5ad9a3e3b8d9ae80ded.camel@kernel.org>
Date:   Wed, 21 Jun 2023 15:04:17 -0400
From:   Jeff Layton <jlayton@...nel.org>
To:     Colin Ian King <colin.i.king@...il.com>,
        Chuck Lever <chuck.lever@...cle.com>,
        Neil Brown <neilb@...e.de>,
        Olga Kornievskaia <kolga@...app.com>,
        Dai Ngo <Dai.Ngo@...cle.com>, Tom Talpey <tom@...pey.com>,
        linux-nfs@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] nfsd: remove redundant assignments to variable len

On Wed, 2023-06-21 at 15:52 +0100, Colin Ian King wrote:
> There are a few assignments to variable len where the value is not
> being read and so the assignments are redundant and can be removed.
> In one case, the variable len can be removed completely. Cleans up
> 4 clang scan warnings of the form:
> 
> fs/nfsd/export.c:100:7: warning: Although the value stored to 'len'
> is used in the enclosing expression, the value is never actually
> read from 'len' [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>  fs/nfsd/export.c | 12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)
> 
> diff --git a/fs/nfsd/export.c b/fs/nfsd/export.c
> index ae85257b4238..11a0eaa2f914 100644
> --- a/fs/nfsd/export.c
> +++ b/fs/nfsd/export.c
> @@ -97,7 +97,7 @@ static int expkey_parse(struct cache_detail *cd, char *mesg, int mlen)
>  		goto out;
>  
>  	err = -EINVAL;
> -	if ((len=qword_get(&mesg, buf, PAGE_SIZE)) <= 0)
> +	if (qword_get(&mesg, buf, PAGE_SIZE) <= 0)
>  		goto out;
>  
>  	err = -ENOENT;
> @@ -107,7 +107,7 @@ static int expkey_parse(struct cache_detail *cd, char *mesg, int mlen)
>  	dprintk("found domain %s\n", buf);
>  
>  	err = -EINVAL;
> -	if ((len=qword_get(&mesg, buf, PAGE_SIZE)) <= 0)
> +	if (qword_get(&mesg, buf, PAGE_SIZE) <= 0)
>  		goto out;
>  	fsidtype = simple_strtoul(buf, &ep, 10);
>  	if (*ep)
> @@ -593,7 +593,6 @@ static int svc_export_parse(struct cache_detail *cd, char *mesg, int mlen)
>  {
>  	/* client path expiry [flags anonuid anongid fsid] */
>  	char *buf;
> -	int len;
>  	int err;
>  	struct auth_domain *dom = NULL;
>  	struct svc_export exp = {}, *expp;
> @@ -609,8 +608,7 @@ static int svc_export_parse(struct cache_detail *cd, char *mesg, int mlen)
>  
>  	/* client */
>  	err = -EINVAL;
> -	len = qword_get(&mesg, buf, PAGE_SIZE);
> -	if (len <= 0)
> +	if (qword_get(&mesg, buf, PAGE_SIZE) <= 0)
>  		goto out;
>  
>  	err = -ENOENT;
> @@ -620,7 +618,7 @@ static int svc_export_parse(struct cache_detail *cd, char *mesg, int mlen)
>  
>  	/* path */
>  	err = -EINVAL;
> -	if ((len = qword_get(&mesg, buf, PAGE_SIZE)) <= 0)
> +	if (qword_get(&mesg, buf, PAGE_SIZE) <= 0)
>  		goto out1;
>  
>  	err = kern_path(buf, 0, &exp.ex_path);
> @@ -665,7 +663,7 @@ static int svc_export_parse(struct cache_detail *cd, char *mesg, int mlen)
>  			goto out3;
>  		exp.ex_fsid = an_int;
>  
> -		while ((len = qword_get(&mesg, buf, PAGE_SIZE)) > 0) {
> +		while (qword_get(&mesg, buf, PAGE_SIZE) > 0) {
>  			if (strcmp(buf, "fsloc") == 0)
>  				err = fsloc_parse(&mesg, buf, &exp.ex_fslocs);
>  			else if (strcmp(buf, "uuid") == 0)

Reviewed-by: Jeff Layton <jlayton@...nel.org>