linux-kernel - Re: [PATCH v1 1/1] usb: ulpi: Make container_of() no-op in to_ulpi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2023062144-impose-wrecking-2315@gregkh>
Date:   Wed, 21 Jun 2023 21:08:06 +0200
From:   Greg KH <greg@...ah.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Subject: Re: [PATCH v1 1/1] usb: ulpi: Make container_of() no-op in
 to_ulpi_dev()

On Wed, Jun 21, 2023 at 07:31:22PM +0300, Andy Shevchenko wrote:
> Move embedded struct device member to make container_of() noop
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  include/linux/ulpi/driver.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/ulpi/driver.h b/include/linux/ulpi/driver.h
> index c7a1810373e3..a8cb617a3028 100644
> --- a/include/linux/ulpi/driver.h
> +++ b/include/linux/ulpi/driver.h
> @@ -15,9 +15,9 @@ struct ulpi_ops;
>   * @dev: device interface
>   */
>  struct ulpi {
> +	struct device dev;
>  	struct ulpi_device_id id;
>  	const struct ulpi_ops *ops;
> -	struct device dev;

CPUs don't like doing pointer math anymore?  :)

I'll go queue this up, thanks for the micro-optimization.

greg k-h