linux-kernel - Re: [PATCH v3 0/2] Avoid re-initializing XHCI HC during removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ae1a7788-acdd-8964-1450-61a741386fbd@quicinc.com>
Date:   Wed, 21 Jun 2023 12:46:03 -0700
From:   Wesley Cheng <quic_wcheng@...cinc.com>
To:     <mathias.nyman@...el.com>, <gregkh@...uxfoundation.org>
CC:     <linux-kernel@...r.kernel.org>, <linux-usb@...r.kernel.org>
Subject: Re: [PATCH v3 0/2] Avoid re-initializing XHCI HC during removal

Friendly ping to see if there are any review feedback/concerns with this 
series?

Thanks
Wesley Cheng

On 5/31/2023 3:27 PM, Wesley Cheng wrote:
> There is an extra amount of overhead being adding to XHCI HCD removal
> cases when the HCD needs to undergo a runtime resume.  The xhc_reinit
> logic will attempt to restart the HC if there is a HCE observed during
> resume.  However, in the removal case, this is not required as the
> XHCI stop/halt will execute the same operations.  In addition, it isn't
> needed that the HC be placed back into the running state if it is being
> removed.
> 
> Changes in v3:
> - Update xhci-plat to set the removal flag before issuing the runtime PM
> get
> 
> Changes in v2:
> - Fixed spacing issue
> 
> Wesley Cheng (2):
>    usb: host: xhci: Do not re-initialize the XHCI HC if being removed
>    usb: host: xhci-plat: Set XHCI_STATE_REMOVING before resuming XHCI HC
> 
>   drivers/usb/host/xhci-plat.c | 2 +-
>   drivers/usb/host/xhci.c      | 3 ++-
>   2 files changed, 3 insertions(+), 2 deletions(-)
>