linux-kernel - Re: [PATCH v1 2/2] platform/x86: wmi: Replace open coded guid_parse_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f674805-b773-be24-4f27-1c86fbf1e3f6@gmx.de>
Date:   Wed, 21 Jun 2023 23:21:39 +0200
From:   Armin Wolf <W_Armin@....de>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Hans de Goede <hdegoede@...hat.com>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Mark Gross <markgross@...nel.org>
Subject: Re: [PATCH v1 2/2] platform/x86: wmi: Replace open coded
 guid_parse_and_compare()

Am 21.06.23 um 17:11 schrieb Andy Shevchenko:

> Even though we have no issues in the code, let's replace the open
> coded guid_parse_and_compare().
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>   drivers/platform/x86/wmi.c | 6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c
> index 098512a53170..a78ddd83cda0 100644
> --- a/drivers/platform/x86/wmi.c
> +++ b/drivers/platform/x86/wmi.c
> @@ -1241,11 +1241,7 @@ static bool guid_already_parsed_for_legacy(struct acpi_device *device, const gui
>   	list_for_each_entry(wblock, &wmi_block_list, list) {
>   		/* skip warning and register if we know the driver will use struct wmi_driver */
>   		for (int i = 0; allow_duplicates[i] != NULL; i++) {
> -			guid_t tmp;
> -
> -			if (guid_parse(allow_duplicates[i], &tmp))
> -				continue;
> -			if (guid_equal(&tmp, guid))
> +			if (guid_parse_and_compare(allow_duplicates[i], guid))
>   				return false;
>   		}
>   		if (guid_equal(&wblock->gblock.guid, guid)) {

Works on my Dell Inspiron 3505, so for this patch:
Tested-by: Armin Wolf <W_Armin@....de>

Armin Wolf