linux-kernel - Re: [PATCH v1 1/2] platform/x86: wmi: Break possible infinite loop when parsing GUID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b4dc2571-1163-805a-f92b-30dcc8b69246@gmx.de>
Date:   Wed, 21 Jun 2023 23:50:51 +0200
From:   Armin Wolf <W_Armin@....de>
To:     Barnabás Pőcze <pobrn@...tonmail.com>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Hans de Goede <hdegoede@...hat.com>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
        Mark Gross <markgross@...nel.org>
Subject: Re: [PATCH v1 1/2] platform/x86: wmi: Break possible infinite loop
 when parsing GUID

Am 21.06.23 um 23:29 schrieb Barnabás Pőcze:

> Hi
>
>
> 2023. június 21., szerda 23:20 keltezéssel, Armin Wolf <W_Armin@....de> írta:
>
>> [...]
>>> @@ -895,11 +901,7 @@ static int wmi_dev_match(struct device *dev, struct device_driver *driver)
>>>    		return 0;
>>>
>>>    	while (*id->guid_string) {
>>> -		guid_t driver_guid;
>>> -
>>> -		if (WARN_ON(guid_parse(id->guid_string, &driver_guid)))
>> Hi,
>>
>> just an idea: how about printing an error/debug message in case of an malformed GUID?
>> This could be useful when searching for typos in GUIDs used by WMI drivers.
>> [...]
> Wouldn't it be better to change `__wmi_driver_register()` to check that?
>
>
> Regards,
> Barnabás Pőcze

Good point, i guess we can just forget this idea. The original motivation for it was the WARN_ON()
inside wmi_dev_match(), but your right that this is the wrong place to check the GUID formating.

Armin Wolf