linux-kernel - Re: [PATCH v3] ALSA: compress: allow setting codec params after next track

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87v8fhqt7x.wl-tiwai@suse.de>
Date:   Wed, 21 Jun 2023 07:28:50 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:     vkoul@...nel.org, broonie@...nel.org, tiwai@...e.com,
        corbet@....net, alsa-devel@...a-project.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        quic_plai@...cinc.com, quic_mohs@...cinc.com
Subject: Re: [PATCH v3] ALSA: compress: allow setting codec params after next track

On Mon, 19 Jun 2023 11:28:05 +0200,
Srinivas Kandagatla wrote:
> 
> For gapless playback it is possible that each track can have different
> codec profile with same decoder, for example we have WMA album,
> we may have different tracks as WMA v9, WMA v10 and so on
> 
> Or if DSP's like QDSP have abililty to switch decoders on single stream
> for each track, then this call could be used to set new codec parameters.
> 
> Existing code does not allow to change this profile while doing gapless
> playback.
> 
> Reuse existing SNDRV_COMPRESS_SET_PARAMS to set this new track params along
> some additional checks to enforce proper state machine.
> 
> With this new changes now the user can call SNDRV_COMPRESS_SET_PARAMS
> anytime after setting next track and additional check in write should
> also ensure that params are set before writing new data.
> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> ---
> Changes since v2:
>  simplified the logic to allow set_params and udated the documentation accordingly

Applied now.  Thanks.


Takashi