linux-kernel - Re: [PATCH] dt-bindings: crypto: intel,ixp4xx: drop unneeded quotes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <89143a15-6368-0de3-5d76-a942fe877583@linaro.org>
Date:   Wed, 21 Jun 2023 08:40:10 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-crypto@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: crypto: intel,ixp4xx: drop unneeded quotes

On 10/06/2023 00:54, Rob Herring wrote:
> On Fri, Jun 09, 2023 at 04:07:45PM +0200, Krzysztof Kozlowski wrote:
>> Cleanup bindings dropping unneeded quotes. Once all these are fixed,
>> checking for this can be enabled in yamllint.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>> ---
>>  .../devicetree/bindings/crypto/intel,ixp4xx-crypto.yaml         | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> You missed $id and $schema values.
> 
> Within drivers/crypto, there's also:
> 
> diff --git a/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml b/Documentation/devicetree/bi
> ndings/crypto/amlogic,gxl-crypto.yaml
> index ecf98a9e72b2..948e11ebe4ee 100644
> --- a/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml
> +++ b/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml
> @@ -19,8 +19,8 @@ properties:
>  
>    interrupts:
>      items:
> -      - description: "Interrupt for flow 0"
> -      - description: "Interrupt for flow 1"
> +      - description: Interrupt for flow 0
> +      - description: Interrupt for flow 1
>  
>    clocks:
>      maxItems: 1
> 
> Can you add this in here. No reason to split this up more that 1 patch 
> per subsystem really. 

I'll add it. I am also fine for you to squash it or take your scripted
changes/commit if you have it ready.

Best regards,
Krzysztof