linux-kernel - Re: [PATCH] mips: ralink: introduce commonly used remap node function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <TYAP286MB031554B338E2379CB87273ADBC5DA@TYAP286MB0315.JPNP286.PROD.OUTLOOK.COM>
Date:   Wed, 21 Jun 2023 09:09:25 +0800
From:   Shiji Yang <yangshiji66@...look.com>
To:     sergio.paracuellos@...il.com
Cc:     angelogioacchino.delregno@...labora.com, john@...ozen.org,
        linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        linux-mips@...r.kernel.org, matthias.bgg@...il.com,
        tsbogend@...ha.franken.de
Subject: Re: [PATCH] mips: ralink: introduce commonly used remap node function

>On Tue, Jun 20, 2023 at 1:46 PM Shiji Yang <yangshiji66@...look.com> wrote:
>>
>> The ralink_of_remap() function is repeated several times on SoC specific
>> source files. They have the same structure, but just differ in compatible
>> strings. In order to make commonly use of these codes, this patch
>> introduces a newly designed mtmips_of_remap_node() function to match and
>> remap all supported system controller and memory controller nodes.
>>
>> Build and run tested on MT7620 and MT7628.
>>
>> Signed-off-by: Shiji Yang <yangshiji66@...look.com>
>> ---
>>  arch/mips/ralink/common.h |  2 --
>>  arch/mips/ralink/mt7620.c |  9 ---------
>>  arch/mips/ralink/mt7621.c |  9 ---------
>>  arch/mips/ralink/of.c     | 42 ++++++++++++++++++++++++++++++++-------
>>  arch/mips/ralink/rt288x.c |  9 ---------
>>  arch/mips/ralink/rt305x.c |  9 ---------
>>  arch/mips/ralink/rt3883.c |  9 ---------
>>  7 files changed, 35 insertions(+), 54 deletions(-)
>
>Awesome! More deletions than additions in arch folders is always a
>good thing :-).
>
>Changes look good to me. Thanks for doing this!
>
>Reviewed-by: Sergio Paracuellos <sergio.paracuellos@...il.com>
>
>Best regards,
>    Sergio Paracuellos

Thank you for your review. After your new system control driver[1] is
merged, with this patch, we can add more compatible IDs to the list.

[1] https://lore.kernel.org/all/20230619040941.1340372-1-sergio.paracuellos@gmail.com/

Best regards,
    Shiji Yang